Merge pull request #777 from particle-iot/bug/sc-132028/compiles-for-archived-version-is-not-working

hugomontero · web-flow · commit 5a7e1848848a · 2024-11-26T15:21:56.000-06:00
bug/sc-132028/compiles-for-archived-version-is-not-working
diff --git a/src/cmd/cloud.js b/src/cmd/cloud.js
@@ -305,10 +305,9 @@ module.exports = class CloudCommand extends CLICommandBase {
 				throw normalizedApiError(error);
 			}
 
-			const validTargets = data.versions.filter((t) => t.release_state !== 'archived');
-			const validTarget = validTargets.filter((t) => t.version === target);
+			const validTarget = data?.versions?.filter((t) => t.version === target);
 			if (!validTarget.length) {
-				throw new VError(['Invalid build target version.', 'Valid targets:'].concat(validTargets.map((v) => `${v.version} ${v.release_state === 'preview' ? '(preview)' : ''}`)).join('\n'));
+				throw new VError(['Invalid build target version.', 'Valid targets:'].concat(data.versions.map((v) => `${v.version} ${v.release_state === 'preview' ? '(preview)' : ''}`)).join('\n'));
 			}
 			targetVersion = validTarget[0].version;
 			this.ui.stdout.write(`Targeting version: ${targetVersion}${os.EOL}`);

Original file line number	Diff line number	Diff line change
`@@ -305,10 +305,9 @@ module.exports = class CloudCommand extends CLICommandBase {`
`305`	`305`	`throw normalizedApiError(error);`
`306`	`306`	`}`
`307`	`307`
`308`		`- const validTargets = data.versions.filter((t) => t.release_state !== 'archived');`
`309`		`- const validTarget = validTargets.filter((t) => t.version === target);`
	`308`	`+ const validTarget = data?.versions?.filter((t) => t.version === target);`
`310`	`309`	`if (!validTarget.length) {`
`311`		- throw new VError(['Invalid build target version.', 'Valid targets:'].concat(validTargets.map((v) => `${v.version} ${v.release_state === 'preview' ? '(preview)' : ''}`)).join('\n'));
	`310`	+ throw new VError(['Invalid build target version.', 'Valid targets:'].concat(data.versions.map((v) => `${v.version} ${v.release_state === 'preview' ? '(preview)' : ''}`)).join('\n'));
`312`	`311`	`}`
`313`	`312`	`targetVersion = validTarget[0].version;`
`314`	`313`	this.ui.stdout.write(`Targeting version: ${targetVersion}${os.EOL}`);