Skip to content

Commit 7985792

Browse files
committed
wip
Signed-off-by: Attila Mészáros <[email protected]>
1 parent c268105 commit 7985792

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

operator-framework-junit5/src/main/java/io/javaoperatorsdk/operator/junit/LocallyRunOperatorExtension.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,14 @@ public class LocallyRunOperatorExtension extends AbstractOperatorExtension {
4747
private static final boolean deleteCRDs =
4848
Boolean.parseBoolean(System.getProperty("testsuite.deleteCRDs", "true"));
4949

50-
private final Operator operator;
50+
private Operator operator;
5151
private final List<ReconcilerSpec> reconcilers;
5252
private final List<PortForwardSpec> portForwards;
5353
private final List<LocalPortForward> localPortForwards;
5454
private final List<Class<? extends CustomResource>> additionalCustomResourceDefinitions;
5555
private final Map<Reconciler, RegisteredController> registeredControllers;
5656
private final Map<String, String> crdMappings;
57+
private final Consumer<ConfigurationServiceOverrider> configurationServiceOverrider;
5758

5859
private LocallyRunOperatorExtension(
5960
List<ReconcilerSpec> reconcilers,
@@ -82,12 +83,13 @@ private LocallyRunOperatorExtension(
8283
this.portForwards = portForwards;
8384
this.localPortForwards = new ArrayList<>(portForwards.size());
8485
this.additionalCustomResourceDefinitions = additionalCustomResourceDefinitions;
85-
configurationServiceOverrider =
86+
this.configurationServiceOverrider =
8687
configurationServiceOverrider != null
8788
? configurationServiceOverrider.andThen(
88-
overrider -> overrider.withKubernetesClient(kubernetesClient))
89-
: overrider -> overrider.withKubernetesClient(kubernetesClient);
90-
this.operator = new Operator(configurationServiceOverrider);
89+
overrider ->
90+
overrider.withKubernetesClient(kubernetesClient).withCloseClientOnStop(false))
91+
: (o -> o.withKubernetesClient(kubernetesClient).withCloseClientOnStop(false));
92+
9193
this.registeredControllers = new HashMap<>();
9294
crdMappings = getAdditionalCRDsFromFiles(additionalCrds, getKubernetesClient());
9395
}
@@ -261,6 +263,7 @@ protected void before(ExtensionContext context) {
261263

262264
additionalCustomResourceDefinitions.forEach(this::applyCrd);
263265
for (var ref : reconcilers) {
266+
this.operator = new Operator(configurationServiceOverrider);
264267
final var config = operator.getConfigurationService().getConfigurationFor(ref.reconciler);
265268
final var oconfig = override(config);
266269

@@ -314,8 +317,6 @@ protected void after(ExtensionContext context) {
314317
iterator.remove();
315318
}
316319

317-
kubernetesClient.close();
318-
319320
try {
320321
this.operator.stop();
321322
} catch (Exception e) {

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/primaryindexer/PrimaryIndexerIT.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@ public class PrimaryIndexerIT {
1818
public static final String RESOURCE_NAME1 = "test1";
1919
public static final String RESOURCE_NAME2 = "test2";
2020

21-
@RegisterExtension
22-
LocallyRunOperatorExtension extension = buildOperator();
21+
@RegisterExtension LocallyRunOperatorExtension extension = buildOperator();
2322

2423
protected LocallyRunOperatorExtension buildOperator() {
2524
return LocallyRunOperatorExtension.builder()

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/subresource/SubResourceUpdateIT.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ class SubResourceUpdateIT {
2323
static LocallyRunOperatorExtension operator =
2424
LocallyRunOperatorExtension.builder()
2525
.withReconciler(SubResourceTestCustomReconciler.class)
26+
.withConfigurationService(o -> o.withCloseClientOnStop(false))
2627
.build();
2728

2829
@Test

0 commit comments

Comments
 (0)