Fix a couple of ansible-lint errors (#126)

* capitalize task names to pass ansible-lint

Signed-off-by: Ravzan Valceanu <[email protected]>

* Truthy value should be one of \[false, true]ansible-lint

Signed-off-by: Ravzan Valceanu <[email protected]>

* All tasks should be named.ansible-lint

Signed-off-by: Ravzan Valceanu <[email protected]>

* Use FQCN for builtin module actions - ansible-lint
Use FQCN for module actions, such `ansible.posix.sysctl`. - ansible-lint
Use FQCN for module actions, such `ansible.posix.selinux`. - ansible-lint
Deprecated module. include - ansible-lint
You can improve the task key order to: name, when, block - ansible-lint

Signed-off-by: Ravzan Valceanu <[email protected]>

* resolve conflict with main use wait_for module instead of pause

Signed-off-by: Ravzan Valceanu <[email protected]>

* add "" to variables in task Wait for opensearch to startup

Signed-off-by: Ravzan Valceanu <[email protected]>

* fix ansible lint inline vs yaml

Signed-off-by: Ravzan Valceanu <[email protected]>

---------

Signed-off-by: Ravzan Valceanu <[email protected]>
Co-authored-by: Ravzan Valceanu <[email protected]>

Author: mpsOxygen

opensearch.yml

@@ -1,12 +1,12 @@
 ---
 
-- name: opensearch installation & configuration
+- name: Opensearch installation & configuration
   hosts: os-cluster
   gather_facts: true
   roles:
     - { role: linux/opensearch }
 
-- name: opensearch dashboards installation & configuration
+- name: Opensearch dashboards installation & configuration
   hosts: dashboards
   gather_facts: true
   roles:

roles/linux/dashboards/handlers/main.yml

@@ -1,3 +1,3 @@
 ---
 - name: restart dashboards
-  systemd: name=dashboards state=restarted enabled=yes
+  ansible.builtin.systemd: name=dashboards state=restarted enabled=true

roles/linux/dashboards/tasks/dashboards.yml

@@ -1,13 +1,13 @@
 ---
 
 - name: Dashboards Install | Download opensearch dashbaord {{ os_dashboards_version }}
-  get_url:
+  ansible.builtin.get_url:
     url: "{{ os_download_url }}-dashboards/{{ os_dashboards_version }}/opensearch-dashboards-{{ os_dashboards_version }}-linux-x64.tar.gz"
     dest: "/tmp/opensearch-dashboards.tar.gz"
   register: download
 
 - name: Dashboards Install | Create opensearch dashboard user
-  user:
+  ansible.builtin.user:
     name: "{{ os_dashboards_user }}"
     state: present
     shell: /bin/false
@@ -16,41 +16,41 @@
   when: download.changed or iac_enable
 
 - name: Dashboards Install | Create home directory
-  file:
+  ansible.builtin.file:
     path: "{{ os_dashboards_home }}"
     state: directory
     owner: "{{ os_dashboards_user }}"
     group: "{{ os_dashboards_user }}"
   when: download.changed or iac_enable
 
 - name: Dashboards Install | Extract the tar file
-  command: chdir=/tmp/ tar -xvzf opensearch-dashboards.tar.gz -C "{{ os_dashboards_home }}" --strip-components=1
+  ansible.builtin.command: chdir=/tmp/ tar -xvzf opensearch-dashboards.tar.gz -C "{{ os_dashboards_home }}" --strip-components=1
   when: download.changed or iac_enable
 
 - name: Dashboards Install | Copy Configuration File
-  template:
+  ansible.builtin.template:
     src: opensearch_dashboards.yml
-    dest: "{{os_conf_dir}}/opensearch_dashboards.yml"
+    dest: "{{ os_conf_dir }}/opensearch_dashboards.yml"
     owner: "{{ os_dashboards_user }}"
     group: "{{ os_dashboards_user }}"
     mode: 0644
-    backup: yes
+    backup: true
 
 - name: Dashboards Install | Set the file ownerships
-  file:
+  ansible.builtin.file:
     dest: "{{ os_dashboards_home }}"
     owner: "{{ os_dashboards_user }}"
     group: "{{ os_dashboards_user }}"
-    recurse: yes
+    recurse: true
 
 - name: Dashboards Install | Set the folder permission
-  file:
+  ansible.builtin.file:
     dest: "{{ os_conf_dir }}"
     owner: "{{ os_dashboards_user }}"
     group: "{{ os_dashboards_user }}"
     mode: 0700
 
 - name: Dashboards Install | create systemd service
-  template:
+  ansible.builtin.template:
     src: dashboards.service
     dest: "{{ systemctl_path }}/dashboards.service"

roles/linux/dashboards/tasks/etchosts.yml

@@ -1,13 +1,13 @@
 ---
 - name: Hosts | populate inventory into hosts file
-  blockinfile:
+  ansible.builtin.blockinfile:
     dest: /etc/hosts
     block: |-
       {% for item in groups['dashboards'] %}
       {{ hostvars[item]['ip'] }} {{ item }}.{{ domain_name }} {{ item }}
       {% endfor %}
     state: present
-    create: yes
-    backup: yes
+    create: true
+    backup: true
     marker: "# Ansible inventory hosts {mark}"
   when: populate_inventory_to_hosts_file

roles/linux/dashboards/tasks/main.yml

@@ -1,33 +1,34 @@
 ---
 
-- hostname:
+- name: Set hostname
+  ansible.builtin.hostname:
     name: "{{ inventory_hostname }}"
 
 # Disabling for Amazon Linux 2 as selinux is disabled by default.
 - name: Disable the selinux
-  selinux:
+  ansible.posix.selinux:
     state: disabled
   when: (ansible_distribution != "Ubuntu") and (ansible_distribution != "Amazon")
 
 - name: Populate the nodes to /etc/hosts
-  import_tasks: etchosts.yml
+  ansible.builtin.import_tasks: etchosts.yml
 
 - name: Tune the system settings
-  import_tasks: tune.yml
+  ansible.builtin.import_tasks: tune.yml
 
-- name: include dashboards installation
-  include: dashboards.yml
+- name: Include dashboards installation
+  ansible.builtin.import_tasks: dashboards.yml
 
 - name: Make sure opensearch dashboards is started
-  service:
+  ansible.builtin.service:
     name: dashboards
     state: started
-    enabled: yes
+    enabled: true
 
 - name: Get all the installed dashboards plugins
-  command: "sudo -u {{ os_dashboards_user }} {{ os_plugin_bin_path }} list"
+  ansible.builtin.command: "sudo -u {{ os_dashboards_user }} {{ os_plugin_bin_path }} list"
   register: list_plugins
 
 - name: Show all the installed dashboards plugins
-  debug:
+  ansible.builtin.debug:
     msg: "{{ list_plugins.stdout }}"

roles/linux/dashboards/tasks/tune.yml

@@ -1,6 +1,6 @@
 ---
 - name: Set open files limit in sysctl.conf
-  sysctl:
+  ansible.posix.sysctl:
     name: fs.file-max
     value: 65536
     state: present

roles/linux/opensearch/handlers/main.yml

@@ -1,10 +1,10 @@
 ---
 # handlers file for opensearch
 - name: reload systemd configuration
-  become: yes
-  command: systemctl daemon-reload
+  become: true
+  ansible.builtin.command: systemctl daemon-reload
 
 # Restart service and ensure it is enabled
 
 - name: restart opensearch
-  systemd: name=opensearch state=restarted enabled=yes
+  ansible.builtin.systemd: name=opensearch state=restarted enabled=yes

roles/linux/opensearch/tasks/etchosts.yml

@@ -1,13 +1,13 @@
 ---
 - name: Hosts | populate inventory into hosts file
-  blockinfile:
+  ansible.builtin.blockinfile:
     dest: /etc/hosts
     block: |-
       {% for item in groups['os-cluster'] %}
       {{ hostvars[item]['ip'] }} {{ item }}.{{ domain_name }} {{ item }}
       {% endfor %}
     state: present
-    create: yes
-    backup: yes
+    create: true
+    backup: true
     marker: "# Ansible inventory hosts {mark}"
   when: populate_inventory_to_hosts_file

roles/linux/opensearch/tasks/main.yml

@@ -1,47 +1,53 @@
 ---
 
-- hostname:
+- name: Set hostname
+  ansible.builtin.hostname:
     name: "{{ inventory_hostname }}"
 
 # Disabling for Amazon Linux 2 as selinux is disabled by default.
 - name: Disable the selinux
-  selinux:
+  ansible.posix.selinux:
     state: disabled
   when: (ansible_distribution != "Ubuntu") and (ansible_distribution != "Amazon")
 
 - name: Populate the nodes to /etc/hosts
-  import_tasks: etchosts.yml
+  ansible.builtin.import_tasks: etchosts.yml
 
 - name: Tune the system settings
-  import_tasks: tune.yml
+  ansible.builtin.import_tasks: tune.yml
 
-- name: include opensearch installation
-  include: opensearch.yml
+- name: Include opensearch installation
+  ansible.builtin.import_tasks: opensearch.yml
 
-- name: include security plugin for opensearch
-  include: security.yml
+- name: Include security plugin for opensearch
+  ansible.builtin.import_tasks: security.yml
 
 # After the cluster forms successfully for the first time,
 # remove the cluster.initial_master_nodes setting from each nodes' configuration.
 - name: Remove `cluster.initial_master_nodes` setting from configuration
-  command: sed -i '/cluster.initial_master_nodes/d' "{{os_conf_dir}}/opensearch.yml"
+  ansible.builtin.command: sed -i '/cluster.initial_master_nodes/d' "{{ os_conf_dir }}/opensearch.yml"
 
 - name: Make sure opensearch is started
-  service:
+  ansible.builtin.service:
     name: opensearch
     state: started
-    enabled: yes
+    enabled: true
 
 - name: Get all the installed ES plugins
-  command: "{{ os_plugin_bin_path }} list"
+  ansible.builtin.command: "{{ os_plugin_bin_path }} list"
   register: list_plugins
 
 - name: Show all the installed ES plugins
-  debug:
+  ansible.builtin.debug:
     msg: "{{ list_plugins.stdout }}"
 
 - name: Wait for opensearch to startup
-  wait_for: host={{ hostvars[inventory_hostname]['ip'] }} port={{os_api_port}} delay=5 connect_timeout=1
+  ansible.builtin.wait_for:
+    host: "{{ hostvars[inventory_hostname]['ip'] }}"
+    port: "{{ os_api_port }}"
+    delay: 5
+    connect_timeout: 1
+    timeout: 120
 
 - name: Check the opensearch status
   ansible.builtin.uri:

roles/linux/opensearch/tasks/opensearch.yml

@@ -1,13 +1,13 @@
 ---
 
 - name: OpenSearch Install | Download opensearch {{ os_version }}
-  get_url:
+  ansible.builtin.get_url:
     url: "{{ os_download_url }}/{{ os_version }}/opensearch-{{ os_version }}-linux-x64.tar.gz"
     dest: "/tmp/opensearch.tar.gz"
   register: download
 
 - name: OpenSearch Install | Create opensearch user
-  user:
+  ansible.builtin.user:
     name: "{{ os_user }}"
     state: present
     shell: /bin/false
@@ -16,39 +16,39 @@
   when: download.changed or iac_enable
 
 - name: OpenSearch Install | Create home directory
-  file:
+  ansible.builtin.file:
     path: "{{ os_home }}"
     state: directory
     owner: "{{ os_user }}"
     group: "{{ os_user }}"
   when: download.changed or iac_enable
 
 - name: OpenSearch Install | Extract the tar file
-  command: chdir=/tmp/ tar -xvzf opensearch.tar.gz -C "{{ os_home }}" --strip-components=1
+  ansible.builtin.command: chdir=/tmp/ tar -xvzf opensearch.tar.gz -C "{{ os_home }}" --strip-components=1
   when: download.changed or iac_enable
 
 - name: OpenSearch Install | Copy Configuration File
-  blockinfile:
+  ansible.builtin.blockinfile:
     block: "{{ lookup('template', 'templates/opensearch-{{ cluster_type }}.yml') }}"
     dest: "{{ os_conf_dir }}/opensearch.yml"
-    backup: yes
+    backup: true
     state: present
-    create: yes
+    create: true
     marker: "## {mark} opensearch main configuration ##"
     owner: "{{ os_user }}"
     group: "{{ os_user }}"
     mode: 0600
 
 - name: OpenSearch Install | Copy jvm.options File for Instance
-  template:
+  ansible.builtin.template:
     src: jvm.options
-    dest: "{{os_conf_dir}}/jvm.options"
+    dest: "{{ os_conf_dir }}/jvm.options"
     owner: "{{ os_user }}"
     group: "{{ os_user }}"
     mode: 0600
-    force: yes
+    force: true
 
 - name: OpenSearch Install | create systemd service
-  template:
+  ansible.builtin.template:
     src: opensearch.service
     dest: "{{ systemctl_path }}/opensearch.service"