Skip to content

Commit 3be7469

Browse files
committed
Remove unnecessary canvas redraws in mouse handlers
1 parent 5123e4c commit 3be7469

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

InteractiveHtmlBom/render.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ function recalcLayerScale(canvasdict) {
347347
function redrawCanvas(layerdict) {
348348
prepareLayer(layerdict);
349349
drawBackground(layerdict);
350-
drawHighlights(layerdict);
350+
drawHighlightsOnLayer(layerdict);
351351
}
352352

353353
function resizeCanvas(layerdict) {
@@ -402,6 +402,7 @@ function handleMouseClick(e, layerdict) {
402402
var reflist = bboxScan(layerdict.layer, v[0], v[1]);
403403
if (reflist.length > 0) {
404404
modulesClicked(reflist);
405+
drawHighlights();
405406
}
406407
}
407408

@@ -414,15 +415,19 @@ function handleMouseUp(e, layerdict) {
414415
layerdict.transform.mousedowny == e.offsetY) {
415416
// This is just a click
416417
handleMouseClick(e, layerdict);
418+
layerdict.transform.mousedown = false;
419+
return;
417420
}
418-
layerdict.transform.mousedown = false;
419421
if (e.which == 3) {
420422
// Reset pan and zoom on right click.
421423
layerdict.transform.panx = 0;
422424
layerdict.transform.pany = 0;
423425
layerdict.transform.zoom = 1;
426+
redrawCanvas(layerdict);
427+
} else if (!redrawOnDrag) {
428+
redrawCanvas(layerdict);
424429
}
425-
redrawCanvas(layerdict);
430+
layerdict.transform.mousedown = false;
426431
}
427432

428433
function handleMouseMove(e, layerdict) {

0 commit comments

Comments
 (0)