Skip to content

Commit f9a26ae

Browse files
authored
Address regression in OpenSSF Token-Permissions (#400)
Related to #289 I noticed an unexpected drop in [OpenSSF Scorecard results](https://scorecard.dev/viewer/?uri=github.com/open-telemetry/otel-arrow) - one of which is the Token-Permissions category. Details include the following warnings: > Warn: topLevel 'security-events' permission set to 'write': .github/workflows/go-ci.yml:5 Warn: no topLevel permission defined: .github/workflows/pipeline-perf-test.yml:1 This PR: * Restricts `security-events: write` to single job in `Go-CI` * Adds an explicit `contents: read` into `Pipeline Performance Tests` per best practice
1 parent 2583e49 commit f9a26ae

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/go-ci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
name: Go-CI
22
permissions:
33
contents: read
4-
# needed for codeql
5-
security-events: write
64

75
on: [push, pull_request]
86

97
jobs:
108

119
build_test:
10+
permissions:
11+
# needed for codeql
12+
security-events: write
1213
runs-on: ubuntu-latest
1314
steps:
1415
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

.github/workflows/pipeline-perf-test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
name: Pipeline Performance Tests
2+
permissions:
3+
contents: read
24

35
on:
46
push:

0 commit comments

Comments
 (0)