You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe
I am using the the OpenTelemetry Operator to auto instrument my NodeJS pods which simplifies a lot the instrumentation setup.
That being said, there are some packages included in the auto-instrumentations-node that I would like more control over. For example, I would like to control some of the optional parameters of the opentelemetry-instrumentation-graphql package (mergeItems, depth etc..).
Describe the solution you'd like to see
The most straightforward solution IMO would be to read the values from the environment with a fallback on the config values passed to the constructor (whichever prevails needs to be determined).
So in the graphql case, I would be able to set:
One alternative would be to not use the Operator to inject auto instrumentation, but instead use a custom registerAutoInstrumentation.js file that I --require when launching my app. In there I can have total control over the options I pass to the various instrumentations.
-> this is more cumbersome and error prone IMO as I have to explicitly write the registerAutoInstrumentation.js file and use it every where I launch my apps.
Another alternative would be to modify my Instrumentation CRD so that the NodeJS spec uses a different image, for ex: Image: ghcr.io/my-image:latest
-> this is better than the previous approach but a bit cumbersome as I have to publish a docker image (forking autoinstrumentation-nodejs:0.53.0) and republish a new image on every update of autoinstrumentation-nodejs
Additional context
The text was updated successfully, but these errors were encountered:
I have the same issue trying to filter some routes I don't want to instrument (like health check routes for instance) and I had to do your second alternative, which is indeed less maintainable
Is your feature request related to a problem? Please describe
I am using the the OpenTelemetry Operator to auto instrument my NodeJS pods which simplifies a lot the instrumentation setup.
That being said, there are some packages included in the
auto-instrumentations-node
that I would like more control over. For example, I would like to control some of the optional parameters of theopentelemetry-instrumentation-graphql
package (mergeItems
,depth
etc..).Describe the solution you'd like to see
The most straightforward solution IMO would be to read the values from the environment with a fallback on the config values passed to the constructor (whichever prevails needs to be determined).
So in the graphql case, I would be able to set:
Describe alternatives you've considered
One alternative would be to not use the Operator to inject auto instrumentation, but instead use a custom
registerAutoInstrumentation.js
file that I--require
when launching my app. In there I can have total control over the options I pass to the various instrumentations.-> this is more cumbersome and error prone IMO as I have to explicitly write the
registerAutoInstrumentation.js
file and use it every where I launch my apps.Another alternative would be to modify my
Instrumentation
CRD so that the NodeJS spec uses a different image, for ex:Image: ghcr.io/my-image:latest
-> this is better than the previous approach but a bit cumbersome as I have to publish a docker image (forking
autoinstrumentation-nodejs:0.53.0
) and republish a new image on every update ofautoinstrumentation-nodejs
Additional context
The text was updated successfully, but these errors were encountered: