Skip to content

Add release artifacts signing to the release process #6855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented May 29, 2025

Resolve #6854

@MrAlias MrAlias added this to the v1.37.0 milestone May 29, 2025
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 29, 2025
@MrAlias MrAlias force-pushed the sign-release-docs branch from c4e334e to 4166eb6 Compare May 29, 2025 19:11
@MrAlias MrAlias marked this pull request as ready for review May 29, 2025 19:12
@MrAlias
Copy link
Contributor Author

MrAlias commented May 29, 2025

@dashpole @dmathieu @XSAM: please let me know the public URL for the key server hosting your GPG key that you sign tags and will sign releases with so I can add them here.

@pellared: please check I have added the correct key. It looks like the previous tags were not signed with this one.

Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.3%. Comparing base (dc210e9) to head (cc30782).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6855   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        263     263           
  Lines      24416   24416           
=====================================
+ Hits       20095   20098    +3     
+ Misses      3939    3936    -3     
  Partials     382     382           

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -651,9 +651,9 @@ should be canceled.

- [Damien Mathieu](https://github.com/dmathieu), Elastic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Damien Mathieu](https://github.com/dmathieu), Elastic
- [Damien Mathieu](https://github.com/dmathieu), Elastic ([GPG](https://keys.openpgp.org/search?q=408B8E44F0873832)

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pellared: please check I have added the correct key. It looks like the previous tags were not signed with this one.

This is correct. I use it since 2025.

@pellared pellared requested a review from dashpole June 3, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLO] Sign our release artifacts
4 participants