Skip to content

Commit 875a258

Browse files
authored
Add docs on when reviews should be cleared (#1556)
1 parent 7153ef2 commit 875a258

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,13 @@ A PR is considered to be **ready to merge** when:
100100
different companies). This is not enforced through technical means
101101
and a PR may be **ready to merge** with a single approval if the change
102102
and its approach have been discussed and consensus reached.
103-
* Major feedbacks are resolved.
103+
* Feedback has been addressed.
104+
* Any substantive changes to your PR will require that you clear any prior
105+
Approval reviews, this includes changes resulting from other feedback. Unless
106+
the approver explicitly stated that their approval will persist across
107+
changes it should be assumed that the PR needs their review again. Other
108+
project members (e.g. approvers, maintainers) can help with this if there are
109+
any questions or if you forget to clear reviews.
104110
* It has been open for review for at least one working day. This gives
105111
people reasonable time to review.
106112
* Trivial changes (typo, cosmetic, doc, etc.) do not have to wait for

0 commit comments

Comments
 (0)