File tree Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Original file line number Diff line number Diff line change @@ -100,7 +100,13 @@ A PR is considered to be **ready to merge** when:
100
100
different companies). This is not enforced through technical means
101
101
and a PR may be ** ready to merge** with a single approval if the change
102
102
and its approach have been discussed and consensus reached.
103
- * Major feedbacks are resolved.
103
+ * Feedback has been addressed.
104
+ * Any substantive changes to your PR will require that you clear any prior
105
+ Approval reviews, this includes changes resulting from other feedback. Unless
106
+ the approver explicitly stated that their approval will persist across
107
+ changes it should be assumed that the PR needs their review again. Other
108
+ project members (e.g. approvers, maintainers) can help with this if there are
109
+ any questions or if you forget to clear reviews.
104
110
* It has been open for review for at least one working day. This gives
105
111
people reasonable time to review.
106
112
* Trivial changes (typo, cosmetic, doc, etc.) do not have to wait for
You can’t perform that action at this time.
0 commit comments