refactor: Remove usage of UnaryServerInterceptor function from otelgrpc #7112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tasdik Rahman <[email protected]>
…tor removal Signed-off-by: Tasdik Rahman <[email protected]>
Signed-off-by: Tasdik Rahman <[email protected]>
… since it's not required anymore after removal of UnaryServerInterceptor Signed-off-by: Tasdik Rahman <[email protected]>
|
@tasdikrahman this looks to be removing the |
mmorel-35
suggested changes
Aug 5, 2025
| @@ -41,6 +41,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - The deprecated `SemVersion` function in `go.opentelemetry.io/contrib/samplers/probability/consistent` is removed, use `Version` instead. (#7072) | |||
| - The deprecated `SemVersion` function is removed in `go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux`, use `Version` function instead. (#7084) | |||
| - The deprecated `SemVersion` function is removed in `go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin`, use `Version` function instead. (#7085) | |||
| - The deprecate `UnaryServerInterceptor` is romoved in the ``go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`, use `NewServerHandler` instead. | |||
There was a problem hiding this comment.
Suggested change
| - The deprecate `UnaryServerInterceptor` is romoved in the ``go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`, use `NewServerHandler` instead. | |
| - The deprecate `UnaryServerInterceptor` is removed in the ``go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`, use `NewServerHandler` instead. |
|
@tasdikrahman thank you for the contribution. This looks to be abandoned, I am going to close this for now. Please reopen when you are able to update and address feedback please. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7107