Skip to content

Commit 79bb705

Browse files
otelecho: Add Code Owner and remove deprecation (#6207)
Resolves #5550 Reverts deprecation from #5645
1 parent 45ba204 commit 79bb705

File tree

9 files changed

+10
-28
lines changed

9 files changed

+10
-28
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
2020

2121
- The function signature of `NewLogProcessor` in `go.opentelemetry.io/contrib/processors/minsev` has changed to accept the added `Severitier` interface instead of a `log.Severity`. (#6116)
2222
- `NewSDK` in `go.opentelemetry.io/contrib/config` now returns a no-op SDK if `disabled` is set to `true`. (#6185)
23+
- The deprecated `go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho` package has found a Code Owner.
24+
The package is no longer deprecated. (#6207)
2325

2426
### Fixed
2527

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/ @open-te
4747
instrumentation/github.com/emicklei/go-restful/otelrestful/ @open-telemetry/go-approvers @dashpole
4848
instrumentation/github.com/gin-gonic/gin/otelgin/ @open-telemetry/go-approvers
4949
instrumentation/github.com/gorilla/mux/otelmux/ @open-telemetry/go-approvers @akats7
50-
instrumentation/github.com/labstack/echo/otelecho/ @open-telemetry/go-approvers
50+
instrumentation/github.com/labstack/echo/otelecho/ @open-telemetry/go-approvers @scorpionknifes
5151
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/ @open-telemetry/go-approvers
5252
instrumentation/google.golang.org/grpc/otelgrpc/ @open-telemetry/go-approvers @dashpole
5353

instrumentation/github.com/labstack/echo/otelecho/doc.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,4 @@
66
//
77
// Currently only the routing of a received message can be instrumented. To do
88
// so, use the Middleware function.
9-
//
10-
// Deprecated: otelecho has no Code Owner.
11-
// After August 21, 2024, it may no longer be supported and may stop
12-
// receiving new releases unless a new Code Owner is found. See
13-
// [this issue] if you would like to become the Code Owner of this module.
14-
//
15-
// [this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5550
169
package otelecho // import "go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho"

instrumentation/github.com/labstack/echo/otelecho/example/README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# labstack echo instrumentation example
22

3-
:warning: Deprecated: otelecho has no Code Owner.
4-
53
An HTTP server using labstack echo and instrumentation. The server has a
64
`/users/:id` endpoint. The server generates span information to
75
`stdout`.

instrumentation/github.com/labstack/echo/otelecho/example/go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Deprecated: otelecho has no Code Owner.
21
module go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho/example
32

43
go 1.22

instrumentation/github.com/labstack/echo/otelecho/example/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010

1111
"github.com/labstack/echo/v4"
1212

13-
"go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho" // nolint:staticcheck // deprecated.
13+
"go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho"
1414
"go.opentelemetry.io/otel"
1515
"go.opentelemetry.io/otel/attribute"
1616
stdout "go.opentelemetry.io/otel/exporters/stdout/stdouttrace"

instrumentation/github.com/labstack/echo/otelecho/go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Deprecated: otelecho has no Code Owner.
21
module go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho
32

43
go 1.22
Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,9 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
/*
5-
Package test validates the otelecho instrumentation with the default SDK.
6-
7-
This package is in a separate module from the instrumentation it tests to
8-
isolate the dependency of the default SDK and not impose this as a transitive
9-
dependency for users.
10-
11-
Deprecated: otelecho has no Code Owner.
12-
After August 21, 2024, it may no longer be supported and may stop
13-
receiving new releases unless a new Code Owner is found. See
14-
[this issue] if you would like to become the Code Owner of this module.
15-
16-
[this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5550
17-
*/
4+
// Package test validates the otelecho instrumentation with the default SDK.
5+
//
6+
// This package is in a separate module from the instrumentation it tests to
7+
// isolate the dependency of the default SDK and not impose this as a transitive
8+
// dependency for users.
189
package test // import "go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho/test"

instrumentation/github.com/labstack/echo/otelecho/test/echo_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616
"github.com/stretchr/testify/assert"
1717
"github.com/stretchr/testify/require"
1818

19-
"go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho" // nolint:staticcheck // deprecated.
19+
"go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho"
2020
"go.opentelemetry.io/otel"
2121
"go.opentelemetry.io/otel/codes"
2222
"go.opentelemetry.io/otel/sdk/trace"

0 commit comments

Comments
 (0)