Skip to content

Commit 018d6ec

Browse files
authored
reporter: fix OTel SemConv (#551)
Signed-off-by: Florian Lehner <[email protected]>
1 parent ecdf5a2 commit 018d6ec

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

reporter/internal/pdata/generate.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import (
1313
"go.opentelemetry.io/collector/pdata/pprofile"
1414
"go.opentelemetry.io/otel/attribute"
1515

16-
semconv "go.opentelemetry.io/otel/semconv/v1.30.0"
16+
semconv "go.opentelemetry.io/otel/semconv/v1.34.0"
1717

1818
"go.opentelemetry.io/ebpf-profiler/libpf"
1919
"go.opentelemetry.io/ebpf-profiler/reporter/samples"
@@ -162,7 +162,7 @@ func (p *Pdata) setProfile(
162162
// semantic convention for build_id, replace these hard coded
163163
// strings.
164164
attrMgr.AppendOptionalString(mapping.AttributeIndices(),
165-
semconv.ProcessExecutableBuildIDGnuKey,
165+
semconv.ProcessExecutableBuildIDGNUKey,
166166
ei.GnuBuildID)
167167
attrMgr.AppendOptionalString(mapping.AttributeIndices(),
168168
semconv.ProcessExecutableBuildIDHtlhashKey,
@@ -226,7 +226,7 @@ func (p *Pdata) setProfile(
226226
for key, value := range traceInfo.EnvVars {
227227
attrMgr.AppendOptionalString(
228228
sample.AttributeIndices(),
229-
attribute.Key("env."+key),
229+
attribute.Key("process.environment_variable."+key),
230230
value)
231231
}
232232

reporter/samples/attrmgr_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212
"go.opentelemetry.io/collector/pdata/pcommon"
1313
"go.opentelemetry.io/collector/pdata/pprofile"
1414
"go.opentelemetry.io/ebpf-profiler/libpf"
15-
semconv "go.opentelemetry.io/otel/semconv/v1.30.0"
15+
semconv "go.opentelemetry.io/otel/semconv/v1.34.0"
1616
)
1717

1818
type attributeStruct struct {

0 commit comments

Comments
 (0)