Fix pprofile DurationNano to be a TypeUint64 #14188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianl
requested review from
a team,
bogdandrutu,
dmathieu,
dmitryax and
mx-psi
as code owners
pcommon.Timestamp better represents a point in time rather than a duration. So keeping the proto field type for DurationNano is a better fit. Signed-off-by: Florian Lehner <[email protected]>
florianl
force-pushed
the
profile-duration
branch
from
80184d1 to
7178c06
Compare
Member
|
Could you also open the -contrib PR that fixes the tests there? |
dmathieu
reviewed
Nov 19, 2025
florianl
added a commit
to florianl/opentelemetry-collector-contrib
that referenced
this pull request
Nov 19, 2025
Complementary change to open-telemetry/opentelemetry-collector#14188. Signed-off-by: Florian Lehner <[email protected]>
Contributor
Author
|
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
dmathieu
reviewed
Nov 19, 2025
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14188 +/- ##
=======================================
Coverage 92.13% 92.14%
=======================================
Files 666 666
Lines 41438 41441 +3
=======================================
+ Hits 38180 38186 +6
+ Misses 2218 2216 -2
+ Partials 1040 1039 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Florian Lehner <[email protected]>
dmathieu
approved these changes
Nov 20, 2025
Signed-off-by: Florian Lehner <[email protected]>
mx-psi
reviewed
Nov 20, 2025
| attribute.NewSet( | ||
| attribute.String(obsconsumer.ComponentOutcome, "success"), | ||
| ): 1186, | ||
| ): 1118, |
Member
There was a problem hiding this comment.
For my understanding, why did the numbers on this file changed?
Contributor
Author
There was a problem hiding this comment.
If my understanding is correct, this number represents the size of pdata and with the change, pdata for profiling shrinked.
Member
There was a problem hiding this comment.
Because it goes from a timestamp to an int.
Merged
via the queue into
open-telemetry:main
with commit Nov 20, 2025
40c567e
59 of 60 checks passed
Member
|
open-telemetry/opentelemetry-collector-contrib/pull/44446 needs your help to address the deprecations |
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Complementary change to open-telemetry/opentelemetry-collector#14188. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Florian Lehner <[email protected]> Co-authored-by: Vihas Makwana <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
#### Description The `Duration` and `SetDuration` methods were deprecated in #14188, and their implementations are now no-ops, causing [a benchmark to fail](https://github.com/open-telemetry/opentelemetry-collector/actions/runs/19668308741/job/56330560134). I updated the benchmark to use `DurationNano` and `SetDurationNano` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pcommon.Timestamp better represents a point in time rather than a duration. So keeping the proto field type for DurationNano is a better fit.
Corresponding Collector-contrib change: open-telemetry/opentelemetry-collector-contrib#44397
ping @open-telemetry/profiling-approvers
Link to tracking issue
Fixes #
Testing
Documentation