Ensure service service.instance.id is the same for all the signals when it is autogenerated

[iblancasa]

Fixes #14140.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.23%. Comparing base (a9691ee) to head (702eff9).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14141      +/-   ##
==========================================
- Coverage   92.24%   92.23%   -0.01%     
==========================================
  Files         658      658              
  Lines       41168    41181      +13     
==========================================
+ Hits        37977    37985       +8     
- Misses       2184     2187       +3     
- Partials     1007     1009       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[axw]

😬 thanks for the fix/sorry for the bug.

It may be too big of a change now, but I wish the instance ID configuration were not buried in the telemetry config, since it may be used for other purposes...

Just one question really: can we simplify the newResource function so it is only used by CreateResource, and everything else uses the result?

[axw]

Thanks @iblancasa. Just a couple of other non-blocking comments. I'm happy to follow up.

[iblancasa]

@open-telemetry/collector-maintainers can we merge this?