[xpdata] Add high-level API for managing entities attached to resources #14039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
entity-helpers
branch
2 times, most recently
from
39ce4db to
eae874d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14039 +/- ##
==========================================
+ Coverage 91.61% 91.64% +0.02%
==========================================
Files 655 658 +3
Lines 42793 42909 +116
==========================================
+ Hits 39205 39322 +117
+ Misses 2765 2764 -1
Partials 823 823 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmitryax
force-pushed
the
entity-helpers
branch
6 times, most recently
from
c30ef53 to
f85193f
Compare
ArthurSens
reviewed
Oct 18, 2025
Member
There was a problem hiding this comment.
Nit:
Reading the Entity OTEP, I'm constantly reading the terms "Identifying" and "Descriptive". Would it make sense to keep the same terminology in the API to improve readability? I'm making code suggestions in just two parts of the code, but this would apply to all other appearances of ID and Description.
On the other hand, ID is shorter and easily understandable as well; feel free to ignore if you prefer the current naming.
ArthurSens
reviewed
Oct 18, 2025
5 tasks
dmitryax
added a commit
to dmitryax/opentelemetry-collector
that referenced
this pull request
Oct 21, 2025
When entities are defined, mdatagen generates `AssociateWith{EntityType}()` methods on ResourceBuilder that associate resources with entity types using the entity refs API. The entities section is backward compatible - existing metadata.yaml files without entities continue to work as before.
This change is fully additive for now. The generated Go API is experimental and will change once open-telemetry#14039 is merged.
dmitryax
added a commit
to dmitryax/opentelemetry-collector
that referenced
this pull request
Oct 21, 2025
When entities are defined, mdatagen generates `AssociateWith{EntityType}()` methods on ResourceBuilder that associate resources with entity types using the entity refs API. The entities section is backward compatible - existing metadata.yaml files without entities continue to work as before.
This change is fully additive for now. The generated Go API is experimental and will change once open-telemetry#14039 is merged.
dmitryax
added a commit
to dmitryax/opentelemetry-collector
that referenced
this pull request
Oct 21, 2025
When entities are defined, mdatagen generates `AssociateWith{EntityType}()` methods on ResourceBuilder that associate resources with entity types using the entity refs API. The entities section is backward compatible - existing metadata.yaml files without entities continue to work as before.
This change is fully additive for now. The generated Go API is experimental and will change once open-telemetry#14039 is merged.
dmitryax
force-pushed
the
entity-helpers
branch
2 times, most recently
from
014d3e9 to
d2c8649
Compare
Introduce `Entity`, `EntitySlice`, and `EntityAttributeMap` types that provide a user-friendly interface for working with resource entities. The new API ensures consistency between entity and resource attributes by sharing the underlying attribute map, and prevents attribute conflicts between entities. This API may eventually replace the generated protobuf-based API for better usability.
dmitryax
force-pushed
the
entity-helpers
branch
from
d2c8649 to
0ec63be
Compare
ChrsMark
approved these changes
Oct 23, 2025
bogdandrutu
approved these changes
Oct 23, 2025
dmitryax
added a commit
to dmitryax/opentelemetry-collector
that referenced
this pull request
Nov 4, 2025
When entities are defined, mdatagen generates `AssociateWith{EntityType}()` methods on ResourceBuilder that associate resources with entity types using the entity refs API. The entities section is backward compatible - existing metadata.yaml files without entities continue to work as before.
This change is fully additive for now. The generated Go API is experimental and will change once open-telemetry#14039 is merged.
dmitryax
added a commit
to dmitryax/opentelemetry-collector
that referenced
this pull request
Nov 4, 2025
When entities are defined, mdatagen generates `AssociateWith{EntityType}()` methods on ResourceBuilder that associate resources with entity types using the entity refs API. The entities section is backward compatible - existing metadata.yaml files without entities continue to work as before.
This change is fully additive for now. The generated Go API is experimental and will change once open-telemetry#14039 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
Entity,EntitySlice, andEntityAttributeMaptypes that provide a user-friendly interface for working with resource entities. The new API ensures consistency between entity and resource attributes by sharing the underlying attribute map, and prevents attribute conflicts between entities. This API should eventually replace the generated protobuf-based API for better usability.Resolves #14042