Skip to content

Conversation

@dmitryax
Copy link
Member

Add RemoveIf method to primitive slice types (StringSlice, Int64Slice, UInt64Slice, Float64Slice, Int32Slice, ByteSlice) implemented consistently with other slices

Add `RemoveIf` method to primitive slice types (StringSlice, Int64Slice, UInt64Slice, Float64Slice, Int32Slice, ByteSlice) implemented consistently with other slices
@dmitryax dmitryax requested review from a team and bogdandrutu as code owners October 15, 2025 01:39
@dmitryax dmitryax closed this Oct 15, 2025
@dmitryax dmitryax deleted the entity-helpers branch October 15, 2025 01:42
@dmitryax
Copy link
Member Author

Replaced by #14028

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 73.33333% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.62%. Comparing base (c854264) to head (77c32e2).

Files with missing lines Patch % Lines
pdata/pcommon/generated_byteslice.go 73.33% 3 Missing and 1 partial ⚠️
pdata/pcommon/generated_float64slice.go 73.33% 3 Missing and 1 partial ⚠️
pdata/pcommon/generated_int32slice.go 73.33% 3 Missing and 1 partial ⚠️
pdata/pcommon/generated_int64slice.go 73.33% 3 Missing and 1 partial ⚠️
pdata/pcommon/generated_stringslice.go 73.33% 3 Missing and 1 partial ⚠️
pdata/pcommon/generated_uint64slice.go 73.33% 3 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (73.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14027      +/-   ##
==========================================
- Coverage   91.67%   91.62%   -0.05%     
==========================================
  Files         654      654              
  Lines       42619    42709      +90     
==========================================
+ Hits        39069    39131      +62     
- Misses       2738     2759      +21     
- Partials      812      819       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant