Fix Helpers For Marshalling And Unmarshalling pcommon.Value #13945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahadzaryab1
requested review from
a team,
bogdandrutu and
dmitryax
as code owners
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13945 +/- ##
==========================================
- Coverage 91.67% 91.63% -0.04%
==========================================
Files 654 654
Lines 42658 42659 +1
==========================================
- Hits 39106 39091 -15
- Misses 2738 2750 +12
- Partials 814 818 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
approved these changes
Oct 8, 2025
Member
|
Could you add a changelog entry? |
Contributor
Author
@dmathieu Done! |
dmathieu
reviewed
Oct 10, 2025
.chloggen/fix-anyvalue-json.yaml
Outdated
| change_type: 'enhancement' | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) | ||
| component: 'xpdata' |
dmathieu
reviewed
Oct 10, 2025
dmathieu
approved these changes
Oct 10, 2025
Contributor
Author
|
@dmathieu is this PR good to go? |
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
force-pushed
the
fix-anyvalue-json
branch
from
214687a to
81fa069
Compare
Member
|
It needs review/merge by a maintainer. |
bogdandrutu
approved these changes
Oct 13, 2025
Merged
via the queue into
open-telemetry:main
with commit Oct 13, 2025
a96eab1
70 of 75 checks passed
Contributor
|
Thank you for your contribution @mahadzaryab1! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Merged
4 tasks
yurishkuro
pushed a commit
to jaegertracing/jaeger
that referenced
this pull request
Nov 2, 2025
#7627) ## Which problem is this PR solving? - Towards #7134 and #7135 ## Description of the changes - This PR adds support for map and slice attributes in ClickHouse storage. It does so by leveraging the new API added in open-telemetry/opentelemetry-collector#13945 to Marshal the attributes to JSON and then storing them as Base64 encoded strings ## How was this change tested? - CI / unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pcommon.Value. Sinceotlpcommon.AnyValueis an internal type, the current helpers are not useful as a public API.Link to tracking issue
Fixes #13837 (original issue #12826)
Testing