Skip to content

Conversation

@dmathieu
Copy link
Member

This was missed in my previous PR. The timestamp_unix_nano field has changed to be a fixed rather than uint.
See https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/profiles/v1development/profiles.proto#L257

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 11, 2025
@dmathieu dmathieu marked this pull request as ready for review September 11, 2025 14:17
@dmathieu dmathieu requested review from a team, bogdandrutu and dmitryax as code owners September 11, 2025 14:17
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.40%. Comparing base (32475fd) to head (352417f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13825      +/-   ##
==========================================
+ Coverage   91.39%   91.40%   +0.01%     
==========================================
  Files         647      646       -1     
  Lines       42597    42606       +9     
==========================================
+ Hits        38931    38944      +13     
+ Misses       2842     2839       -3     
+ Partials      824      823       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu added the ready-to-merge Code review completed; ready to merge by maintainers label Sep 12, 2025
@bogdandrutu bogdandrutu removed the ready-to-merge Code review completed; ready to merge by maintainers label Sep 12, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Sep 14, 2025
Merged via the queue into open-telemetry:main with commit 2e9dda5 Sep 14, 2025
57 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 14, 2025
@dmathieu dmathieu deleted the pprofile-timestamp-fixed branch September 15, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants