Skip to content

Conversation

@bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Aug 15, 2025

This removes unnecessary duplication of "Profiles" prefix when the struct/package has already profile in it, also brings consistency with proto definition.

@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.86%. Comparing base (b302feb) to head (e964d46).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pdata/pprofile/profiles.go 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (60.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (87.86%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13644      +/-   ##
==========================================
- Coverage   87.88%   87.86%   -0.02%     
==========================================
  Files         632      632              
  Lines       39516    39518       +2     
==========================================
- Hits        34727    34723       -4     
- Misses       3567     3572       +5     
- Partials     1222     1223       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu added this pull request to the merge queue Aug 15, 2025
Merged via the queue into open-telemetry:main with commit 14c39c3 Aug 15, 2025
55 of 57 checks passed
@bogdandrutu bogdandrutu deleted the dep-profiles-dict branch August 15, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants