Skip to content

Conversation

@atoulme
Copy link
Contributor

@atoulme atoulme commented Jul 26, 2025

Description

Remove undocumented handling of DIST_* environment variables replacements

Link to tracking issue

Fixes #13335

@atoulme atoulme requested a review from a team as a code owner July 26, 2025 05:48
@atoulme atoulme requested a review from codeboten July 26, 2025 05:48
@codecov
Copy link

codecov bot commented Jul 26, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.77%. Comparing base (7be639f) to head (03f7e75).

Files with missing lines Patch % Lines
cmd/builder/internal/command.go 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13493      +/-   ##
==========================================
- Coverage   91.78%   91.77%   -0.01%     
==========================================
  Files         537      537              
  Lines       30999    30992       -7     
==========================================
- Hits        28453    28444       -9     
  Misses       2015     2015              
- Partials      531      533       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atoulme atoulme force-pushed the remove_dist_handling branch from c082833 to 03f7e75 Compare July 26, 2025 06:16
@atoulme atoulme force-pushed the remove_dist_handling branch from 03f7e75 to e0de234 Compare July 26, 2025 16:46
@bogdandrutu
Copy link
Member

@atoulme can you look into the failing check? I restarted now, maybe it passes.

@atoulme
Copy link
Contributor Author

atoulme commented Jul 26, 2025

@atoulme can you look into the failing check? I restarted now, maybe it passes.

Seems to fail on main as well: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/16542475534/job/46785579476#step:10:23

@bogdandrutu bogdandrutu added this pull request to the merge queue Jul 26, 2025
Merged via the queue into open-telemetry:main with commit b5f3b1d Jul 26, 2025
55 of 56 checks passed
@atoulme atoulme deleted the remove_dist_handling branch July 27, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cmd/builder: decide what to do w/ dist_

2 participants