Skip to content

Conversation

@bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jul 9, 2025

Fixes #13313

@bogdandrutu bogdandrutu requested review from a team, dmathieu, dmitryax and mx-psi as code owners July 9, 2025 11:37
@bogdandrutu bogdandrutu force-pushed the support-batch-sizer branch 3 times, most recently from 440446e to 960dc35 Compare July 9, 2025 13:48
@bogdandrutu bogdandrutu force-pushed the support-batch-sizer branch from 960dc35 to 910b123 Compare July 9, 2025 16:19
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 62.16216% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (e8ccfc3) to head (910b123).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...orter/exporterhelper/internal/queuebatch/config.go 33.33% 8 Missing ⚠️
...rter/exporterhelper/internal/queuebatch/batcher.go 75.00% 3 Missing and 1 partial ⚠️
.../exporterhelper/internal/queuebatch/queue_batch.go 66.66% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (62.16%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13362      +/-   ##
==========================================
- Coverage   91.56%   91.48%   -0.09%     
==========================================
  Files         528      528              
  Lines       29472    29475       +3     
==========================================
- Hits        26985    26964      -21     
- Misses       1961     1981      +20     
- Partials      526      530       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu added this pull request to the merge queue Jul 9, 2025
Merged via the queue into open-telemetry:main with commit 30edb9d Jul 9, 2025
51 of 56 checks passed
@bogdandrutu bogdandrutu deleted the support-batch-sizer branch July 9, 2025 18:43
github-merge-queue bot pushed a commit that referenced this pull request Jul 10, 2025
songy23 pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Aug 8, 2025
#### Description

Fixes a regression, root cause a change in
open-telemetry/opentelemetry-collector#13362

#### Link to tracking issue
Fixes #41241

#### Testing

Restored two tests.

#### Documentation

n/a

---------

Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep standalone sizer in configuration

3 participants