[exporterhelper] Fix exporter.PersistRequestContext feature gate

[dmitryax]

It was ignored before because the PersistRequestContextOnRead and PersistRequestContextOnWrite variables were initialized before the feature gate was set from the command line arguments.

Resolves #13342

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.56%. Comparing base (120736c) to head (8af6b02).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13359      +/-   ##
==========================================
+ Coverage   91.52%   91.56%   +0.04%     
==========================================
  Files         528      528              
  Lines       29478    29478              
==========================================
+ Hits        26980    26992      +12     
+ Misses       1969     1960       -9     
+ Partials      529      526       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dmathieu]

Couldn't this be:

Suggested change

	PersistRequestContextOnRead = func() bool { return PersistRequestContextFeatureGate.IsEnabled() }
	PersistRequestContextOnWrite = func() bool { return PersistRequestContextFeatureGate.IsEnabled() }
	PersistRequestContextOnRead = PersistRequestContextFeatureGate.IsEnabled
	PersistRequestContextOnWrite = PersistRequestContextFeatureGate.IsEnabled

[bogdandrutu]

It can, but I would suggest we just remove the 2 temp vars and use the feature gate all the time.

[dmitryax]

It can, but I would suggest we just remove the 2 temp vars and use the feature gate all the time.

Yeah, but otherwise it's very complicated to test the cases when the feature gate is changed while there is data in the persistent store

[sfc-gh-bdrutu]

Sure, but you need only the happy path to be tested in the e2e with real ptrace. For the enable/disable you can have unit-tests directly in the persistent_queue_test file and have this featuregate passed in the constructor (as hidden property) to the queue.

[dmitryax]

I try this as a follow-up