[chore][RFC] Simplifying stateful behavior #13224
Conversation
VihasMakwana
requested review from
a team,
bogdandrutu,
codeboten,
dmitryax and
mx-psi
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13224 +/- ##
==========================================
+ Coverage 91.51% 91.56% +0.04%
==========================================
Files 522 522
Lines 28988 29089 +101
==========================================
+ Hits 26529 26635 +106
+ Misses 1939 1936 -3
+ Partials 520 518 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mx-psi @dmitryax @bogdandrutu @codeboten I'll announce this RFC in today's SIG. I'll try my best to join next iteration of SIG i.e. the one occurring at 9:00 PT. |
VihasMakwana
force-pushed
the
stateful-rfc
branch
from
9f0bc7c to
853a9fd
Compare
VihasMakwana
changed the title
VihasMakwana
force-pushed
the
stateful-rfc
branch
from
9ef6df0 to
29cc358
Compare
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Promotes @VihasMakwana as triager. @VihasMakwana is a contrib triager and has been doing excellent work in core, including pushing for RFCs and features such as #13256, #13224 and #11775. Thank you for your work @VihasMakwana ! cc @open-telemetry/collector-approvers
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
I have personally been a bit underwater for the past two months, so apologies for the delay.
Converters are 'just another' type of component, so I think it would be interesting to just offer this component in contrib (maybe not as part of the distribution, at least at first) and gather feedback about it.
|
@mx-psi I see. I'll open up a PR in contrib to gather feedback. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
2 participants
Description
This PR adds a new RFC to simplify enabling statefulness. It is a part of open-telemetry/opentelemetry-collector-contrib#35013.
An open question to folks is:
Which directory to use for storing offsets if the feature gate is enabled?
Link to tracking issue
Relates open-telemetry/opentelemetry-collector-contrib#35013