From 77a0e6c71d1a42d36a49afcf58ccb89d8442301b Mon Sep 17 00:00:00 2001 From: Pablo Baeyens Date: Tue, 20 Aug 2024 10:59:21 +0200 Subject: [PATCH] [confmap] Mark module as stable --- .chloggen/mx-psi_confmap-1.0.yaml | 25 +++++++++++++++++++++++++ confmap/confmap_test.go | 2 -- versions.yaml | 2 +- 3 files changed, 26 insertions(+), 3 deletions(-) create mode 100644 .chloggen/mx-psi_confmap-1.0.yaml diff --git a/.chloggen/mx-psi_confmap-1.0.yaml b/.chloggen/mx-psi_confmap-1.0.yaml new file mode 100644 index 00000000000..421782936da --- /dev/null +++ b/.chloggen/mx-psi_confmap-1.0.yaml @@ -0,0 +1,25 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: enhancement + +# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) +component: confmap + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Mark module as stable + +# One or more tracking issues or pull requests related to the change +issues: [9379] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: [] diff --git a/confmap/confmap_test.go b/confmap/confmap_test.go index 32bf272d5d8..5b4a1ad674f 100644 --- a/confmap/confmap_test.go +++ b/confmap/confmap_test.go @@ -113,7 +113,6 @@ func TestExpandNilStructPointersHookFunc(t *testing.T) { // assert.False(t, *cfg.Boolean) assert.Nil(t, cfg.Struct) assert.NotNil(t, cfg.MapStruct) - // TODO: Investigate this unexpected result. assert.Equal(t, &Struct{}, cfg.MapStruct["struct"]) } @@ -140,7 +139,6 @@ func TestExpandNilStructPointersHookFuncDefaultNotNilConfigNil(t *testing.T) { assert.NotNil(t, cfg.Struct) assert.Equal(t, s1, cfg.Struct) assert.NotNil(t, cfg.MapStruct) - // TODO: Investigate this unexpected result. assert.Equal(t, &Struct{}, cfg.MapStruct["struct"]) } diff --git a/versions.yaml b/versions.yaml index b1ca12a3b20..38a1eb040fe 100644 --- a/versions.yaml +++ b/versions.yaml @@ -8,6 +8,7 @@ module-sets: - go.opentelemetry.io/collector/client - go.opentelemetry.io/collector/featuregate - go.opentelemetry.io/collector/pdata + - go.opentelemetry.io/collector/confmap - go.opentelemetry.io/collector/config/configopaque - go.opentelemetry.io/collector/config/configcompression - go.opentelemetry.io/collector/config/configretry @@ -22,7 +23,6 @@ module-sets: - go.opentelemetry.io/collector/component - go.opentelemetry.io/collector/component/componentstatus - go.opentelemetry.io/collector/component/componentprofiles - - go.opentelemetry.io/collector/confmap - go.opentelemetry.io/collector/confmap/converter/expandconverter - go.opentelemetry.io/collector/confmap/provider/envprovider - go.opentelemetry.io/collector/confmap/provider/fileprovider