Add pipelines.Config to remove duplicate of the pipelines configuration #7854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
pipelinesconfig
branch
7 times, most recently
from
e6f9701 to
58c4529
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
pipelinesconfig
branch
from
58c4529 to
8928fdb
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7854 +/- ##
==========================================
+ Coverage 91.07% 91.12% +0.05%
==========================================
Files 297 298 +1
Lines 14895 14892 -3
==========================================
+ Hits 13565 13570 +5
+ Misses 1052 1046 -6
+ Partials 278 276 -2
☔ View full report in Codecov by Sentry. |
codeboten
approved these changes
Jun 9, 2023
| return fmt.Errorf("references processor %q multiple times", ref) | ||
| } | ||
| procSet[ref] = struct{}{} | ||
| fmt.Printf("service::telemetry config validation failed: %v\n", err) |
There was a problem hiding this comment.
this should return fmt.Errorf()
There was a problem hiding this comment.
I want to do it in a separate PR, since it changes previous behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.