Skip to content

Introduce MergeAndAppendTo for ProfilesDictionary #13138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jun 3, 2025

Description

This introduces MoveAndAppendTo to pprofile.ProfilesDictionary.
While ProfilesDictionary isn't a slice, it only holds slices, and moving/appending them all is needed for #13106.

@github-actions github-actions bot requested review from bogdandrutu and dmitryax June 3, 2025 12:58
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name does not sound clear since merging has some append connotations

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (0f0e1f6) to head (18eff55).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13138   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         508      509    +1     
  Lines       28747    28756    +9     
=======================================
+ Hits        26235    26244    +9     
  Misses       1994     1994           
  Partials      518      518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu
Copy link
Member Author

dmathieu commented Jun 3, 2025

I reused the method name from slices (eg: AttributeTableSlice).
But I'm happy to use another one. Maybe just Merge?

@dmathieu dmathieu marked this pull request as ready for review June 3, 2025 13:16
@dmathieu dmathieu requested review from mx-psi and a team as code owners June 3, 2025 13:16
@bogdandrutu
Copy link
Member

But the idea there is Move source (meaning memory is moved instead of copy) and append that to the destination.

@dmathieu
Copy link
Member Author

dmathieu commented Jun 3, 2025

Sure. MoveTo is already taken though. What's your suggestion?

@github-actions github-actions bot requested a review from bogdandrutu June 4, 2025 10:08
@dmathieu
Copy link
Member Author

dmathieu commented Jun 4, 2025

Upon reflexion, I don't think this is the right approach.
It will make ensuring uniqueness of entries in each table quite difficult.

I'll open other PRs using another approach with the FromAttributeIndices and PutAttribute methods.

@dmathieu dmathieu closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants