[refactor] Migrate persistent queue to consolidated metadata format #13126
+367
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (75.53%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13126 +/- ##
==========================================
- Coverage 91.28% 91.26% -0.03%
==========================================
Files 510 510
Lines 28725 28812 +87
==========================================
+ Hits 26223 26295 +72
- Misses 1988 1991 +3
- Partials 514 526 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please use changes from #13125 |
malus2077
requested review from
mx-psi,
dmathieu and
andrzej-stencel
as code owners
|
Hey… something is wrong here |
malus2077
force-pushed
the
malus2077/refactor-12890
branch
from
250d434 to
4aa8773
Compare
It's done! Apologies, I'm still getting comfortable with git rebase operations. |
bogdandrutu
reviewed
Jun 3, 2025
exporter/exporterhelper/internal/queuebatch/persistent_queue.go
Outdated
Show resolved
Hide resolved
exporter/exporterhelper/internal/queuebatch/persistent_queue.go
Outdated
Show resolved
Hide resolved
exporter/exporterhelper/internal/queuebatch/persistent_queue.go
Outdated
Show resolved
Hide resolved
exporter/exporterhelper/internal/queuebatch/persistent_queue.go
Outdated
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
Embed QueueMetadata directly into persistentQueue, replacing the scattered metadata fields. 1. Add QueueMetadata as a member of persistentQueue. 2. Delete redundant fields (queueSize, readIdx, writeIdx, …). Relates to #13126
|
Please rebase with latest changes |
malus2077
added a commit
to malus2077/opentelemetry-collector
that referenced
this pull request
Jun 5, 2025
…ry#13140) Embed QueueMetadata directly into persistentQueue, replacing the scattered metadata fields. 1. Add QueueMetadata as a member of persistentQueue. 2. Delete redundant fields (queueSize, readIdx, writeIdx, …). Relates to open-telemetry#13126
malus2077
force-pushed
the
malus2077/refactor-12890
branch
from
7d0eef9 to
1acbafc
Compare
malus2077
changed the title
malus2077
changed the title
bogdandrutu
reviewed
Jun 5, 2025
exporter/exporterhelper/internal/queuebatch/persistent_queue.go
Outdated
Show resolved
Hide resolved
exporter/exporterhelper/internal/queuebatch/persistent_queue.go
Outdated
Show resolved
Hide resolved
exporter/exporterhelper/internal/queuebatch/persistent_queue.go
Outdated
Show resolved
Hide resolved
exporter/exporterhelper/internal/queuebatch/persistent_queue.go
Outdated
Show resolved
Hide resolved
exporter/exporterhelper/internal/queuebatch/persistent_queue.go
Outdated
Show resolved
Hide resolved
| return err | ||
| } | ||
|
|
||
| if metadataSizerType != pq.set.sizerType { |
There was a problem hiding this comment.
Let's add support for this in a followup PR, for the moment in this case return error.
There was a problem hiding this comment.
Not returning an error directly here for now. Please see my previous comment.
exporter/exporterhelper/internal/queuebatch/persistent_queue.go
Outdated
Show resolved
Hide resolved
…streamline metadata handling
|
Thanks for the review, @bogdandrutu! Changes are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the persistence strategy to consolidate all relevant queue information (start, stop, in-progress, size) under a single key for each write operation.