Skip to content

[exporterhelper] Propose refactor of internal/queuebatch package #13077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackgopack4 opened this issue May 22, 2025 · 2 comments
Open

[exporterhelper] Propose refactor of internal/queuebatch package #13077

jackgopack4 opened this issue May 22, 2025 · 2 comments

Comments

@jackgopack4
Copy link
Contributor

Component(s)

exporter/exporterhelper

Describe the issue you're reporting

It seems that internal/queuebatch package is growing rather large and interdependent.

Given comments on #12934 (#12934 (comment)), it could be worthwhile to separate a queue/batcher interface and have separate package or packages for the various implementations (i.e. async queue, memory queue, persistent queue as well as default batcher/disabled batcher).

I propose leaving queuebatch as an interface-driven package potentially renaming as something like queuebatchinterface, and creating individual "batcher" and "queue" packages for the implementations. This would be done in multiple steps.

Alternatively, there could be a "queue" and a "batch" internal package that defines the interface and common code, and sub-packages under those package for each queue and batcher implementation.

Would be happy to discuss concerns/advice with regards to this proposal.

Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jackgopack4
Copy link
Contributor Author

so it seems like the dependencies are pretty tight, seeing if I can use dependency inversion with queuebatch and the various queue/batcher implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant