You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that internal/queuebatch package is growing rather large and interdependent.
Given comments on #12934 (#12934 (comment)), it could be worthwhile to separate a queue/batcher interface and have separate package or packages for the various implementations (i.e. async queue, memory queue, persistent queue as well as default batcher/disabled batcher).
I propose leaving queuebatch as an interface-driven package potentially renaming as something like queuebatchinterface, and creating individual "batcher" and "queue" packages for the implementations. This would be done in multiple steps.
Alternatively, there could be a "queue" and a "batch" internal package that defines the interface and common code, and sub-packages under those package for each queue and batcher implementation.
Would be happy to discuss concerns/advice with regards to this proposal.
The text was updated successfully, but these errors were encountered:
so it seems like the dependencies are pretty tight, seeing if I can use dependency inversion with queuebatch and the various queue/batcher implementations
Component(s)
exporter/exporterhelper
Describe the issue you're reporting
It seems that
internal/queuebatch
package is growing rather large and interdependent.Given comments on #12934 (#12934 (comment)), it could be worthwhile to separate a queue/batcher interface and have separate package or packages for the various implementations (i.e. async queue, memory queue, persistent queue as well as default batcher/disabled batcher).
I propose leaving queuebatch as an interface-driven package potentially renaming as something like
queuebatchinterface
, and creating individual "batcher" and "queue" packages for the implementations. This would be done in multiple steps.Alternatively, there could be a "queue" and a "batch" internal package that defines the interface and common code, and sub-packages under those package for each queue and batcher implementation.
Would be happy to discuss concerns/advice with regards to this proposal.
The text was updated successfully, but these errors were encountered: