Skip to content

Add batching capability to the old QueueConfig #12746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team and dmitryax as code owners March 26, 2025 21:33
@bogdandrutu bogdandrutu force-pushed the add-batch-to-config branch 2 times, most recently from 336ebaa to c6dd425 Compare March 26, 2025 21:43
@bogdandrutu bogdandrutu force-pushed the add-batch-to-config branch from c6dd425 to 45d5d51 Compare March 26, 2025 22:07
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 74.54545% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.58%. Comparing base (ea0a4c6) to head (45d5d51).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/internal/queue_sender.go 76.66% 7 Missing ⚠️
...orter/exporterhelper/internal/queuebatch/config.go 75.00% 2 Missing and 1 partial ⚠️
.../exporterhelper/internal/queuebatch/queue_batch.go 66.66% 2 Missing and 1 partial ⚠️
exporter/exporterhelper/queue_batch.go 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (74.54%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12746   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         479      479           
  Lines       26491    26468   -23     
=======================================
- Hits        24262    24242   -20     
+ Misses       1757     1756    -1     
+ Partials      472      470    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codeboten codeboten changed the title Add batching capability to the old QuueueConfig Add batching capability to the old QueueConfig Mar 26, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 26, 2025
Merged via the queue into open-telemetry:main with commit f09817e Mar 27, 2025
53 of 57 checks passed
@bogdandrutu bogdandrutu deleted the add-batch-to-config branch March 27, 2025 00:15
@douglascamata
Copy link
Member

Hey @dmitryax and @bogdandrutu, what's the context of this PR? Why does it have no description? Why is this being done? There are plenty of breaking changes here, it would be nice to let people know why they are being made, what's the plan, objectives, etc.

component: exporterhelper

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Deprecate `QueueConfig` in favor of `QueueBatchConfig`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have include some information about how this will affect the otlp and otlphttpexporters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants