-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Allow users to configure different sizers for memory queue #12708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b66973b
to
1dfedb7
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (77.77%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12708 +/- ##
==========================================
- Coverage 91.54% 91.52% -0.02%
==========================================
Files 480 480
Lines 26456 26452 -4
==========================================
- Hits 24218 24211 -7
- Misses 1772 1774 +2
- Partials 466 467 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
872d839
to
bdef90f
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bdef90f
to
dbb0244
Compare
} | ||
|
||
switch cfg.StorageID != nil { | ||
case true: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a blocker, but since there's only one case, do we need a switch here? (same with the switch at 47)
7c2c26d
Depends on #12706