Skip to content

Allow users to configure different sizers for memory queue #12708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

bogdandrutu
Copy link
Member

Depends on #12706

@bogdandrutu bogdandrutu requested review from a team, mx-psi, dmathieu and dmitryax as code owners March 23, 2025 23:26
@bogdandrutu bogdandrutu force-pushed the allow-sizer branch 7 times, most recently from b66973b to 1dfedb7 Compare March 24, 2025 20:50
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.52%. Comparing base (58370e5) to head (dbb0244).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/internal/queue_sender.go 40.00% 2 Missing and 1 partial ⚠️
.../exporterhelper/internal/queuebatch/queue_batch.go 86.36% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (77.77%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12708      +/-   ##
==========================================
- Coverage   91.54%   91.52%   -0.02%     
==========================================
  Files         480      480              
  Lines       26456    26452       -4     
==========================================
- Hits        24218    24211       -7     
- Misses       1772     1774       +2     
- Partials      466      467       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu force-pushed the allow-sizer branch 2 times, most recently from 872d839 to bdef90f Compare March 24, 2025 21:18
@bogdandrutu bogdandrutu enabled auto-merge March 24, 2025 21:31
@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 24, 2025
}

switch cfg.StorageID != nil {
case true:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker, but since there's only one case, do we need a switch here? (same with the switch at 47)

Merged via the queue into open-telemetry:main with commit 7c2c26d Mar 24, 2025
52 of 56 checks passed
@bogdandrutu bogdandrutu deleted the allow-sizer branch March 24, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants