Skip to content

[chore] bump otel-go deps #12575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Conversation

mattsains
Copy link
Contributor

Description

Upgrading the collector to use opentelemetry-go-contrib v1.35.0/v0.60.0/v0.29.0/v0.15.0/v0.10.0/v0.8.0/v0.7.0

See changelog here: https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.35.0

Link to tracking issue

none available

Testing

I ran make all but happy to run other targets if needed

@mattsains mattsains requested a review from a team as a code owner March 6, 2025 19:10
@mattsains mattsains requested a review from evan-bradley March 6, 2025 19:10
Copy link

linux-foundation-easycla bot commented Mar 6, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

v1.35.0/v0.60.0/v0.29.0/v0.15.0/v0.10.0/v0.8.0/v0.7.0
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (f9bd8ca) to head (9d1a9a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12575   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         469      469           
  Lines       25390    25390           
=======================================
  Hits        23405    23405           
  Misses       1574     1574           
  Partials      411      411           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattsains
Copy link
Contributor Author

My understanding is that the tests are broken because collector-contrib hasn't been updated to the latest go-contrib version. But I can't update it before the collector itself is updated. Not sure what to do here, could use some advice on how to phase this upgrade @open-telemetry/collector-maintainers

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can skip the contrib tests for this PR and get it updated separately

@codeboten codeboten enabled auto-merge March 6, 2025 20:20
@codeboten codeboten added this pull request to the merge queue Mar 6, 2025
@mattsains
Copy link
Contributor Author

@codeboten happy to work on the collector-contrib upgrade too, but I think I need to wait for the next collector release, since the changes in this PR are all going to be transitive dependencies

Merged via the queue into open-telemetry:main with commit ab63cdf Mar 6, 2025
61 of 62 checks passed
@mattsains mattsains deleted the config-update branch March 6, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants