Skip to content

Fix MergeSplit issue that ignores the initial message size #12257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

bogdandrutu
Copy link
Member

This PR simplifies the MergeSplit logic while fixing a bug (see TestMergeSplitManySmall* on how to replicate that). The performance is also slightly improved by reducing some allocations, see:

Before:

goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/collector/exporter/exporterhelper
cpu: Apple M2 Max
BenchmarkSplittingBasedOnItemCountManySmallTraces
BenchmarkSplittingBasedOnItemCountManySmallTraces-12    	     390	   3029960 ns/op	 4850499 B/op	   81094 allocs/op
PASS

After:

goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/collector/exporter/exporterhelper
cpu: Apple M2 Max
BenchmarkSplittingBasedOnItemCountManySmallTraces
BenchmarkSplittingBasedOnItemCountManySmallTraces-12    	     414	   2898061 ns/op	 4850453 B/op	   81092 allocs/op

@bogdandrutu bogdandrutu requested review from mx-psi, dmathieu, a team and dmitryax as code owners February 3, 2025 19:07
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (643a35f) to head (9d77119).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12257      +/-   ##
==========================================
- Coverage   91.30%   91.26%   -0.05%     
==========================================
  Files         465      465              
  Lines       25658    25538     -120     
==========================================
- Hits        23426    23306     -120     
  Misses       1816     1816              
  Partials      416      416              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu added the release:blocker The issue must be resolved before cutting the next release label Feb 3, 2025
@dmitryax dmitryax added this pull request to the merge queue Feb 3, 2025
Merged via the queue into open-telemetry:main with commit a6aaf37 Feb 3, 2025
68 of 71 checks passed
@bogdandrutu bogdandrutu deleted the fix-traces-split branch February 3, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants