[chore] Fix small nits in persistent queue metadata sizer conversion and add tests (#13124)

Signed-off-by: Bogdan Drutu <[email protected]>
Co-authored-by: Alex Boten <[email protected]>

Author: bogdandrutu

exporter/exporterhelper/internal/queuebatch/internal/persistentqueue/sizer_conversion.go

@@ -11,33 +11,33 @@ import (
 
 // Numeric constants for protobuf serialization
 const (
-	SizerTypeBytesValue    int32 = iota // 0
-	SizerTypeItemsValue                 // 1
-	SizerTypeRequestsValue              // 2
+	SizerTypeBytes    int32 = iota // 0
+	SizerTypeItems                 // 1
+	SizerTypeRequests              // 2
 )
 
-// SizerTypeToInt32 converts SizerType to int32 for protobuf serialization
-func SizerTypeToInt32(sizerType request.SizerType) (int32, error) {
+// SizerTypeToProto converts SizerType to int32 for protobuf serialization
+func SizerTypeToProto(sizerType request.SizerType) (int32, error) {
 	switch sizerType {
 	case request.SizerTypeBytes:
-		return SizerTypeBytesValue, nil
+		return SizerTypeBytes, nil
 	case request.SizerTypeItems:
-		return SizerTypeItemsValue, nil
+		return SizerTypeItems, nil
 	case request.SizerTypeRequests:
-		return SizerTypeRequestsValue, nil
+		return SizerTypeRequests, nil
 	default:
 		return -1, fmt.Errorf("invalid sizer type: %v", sizerType)
 	}
 }
 
-// SizerTypeFromInt32 creates SizerType from int32 representation
-func SizerTypeFromInt32(value int32) (request.SizerType, error) {
+// SizerTypeFromProto creates SizerType from int32 representation
+func SizerTypeFromProto(value int32) (request.SizerType, error) {
 	switch value {
-	case SizerTypeBytesValue:
+	case SizerTypeBytes:
 		return request.SizerTypeBytes, nil
-	case SizerTypeItemsValue:
+	case SizerTypeItems:
 		return request.SizerTypeItems, nil
-	case SizerTypeRequestsValue:
+	case SizerTypeRequests:
 		return request.SizerTypeRequests, nil
 	default:
 		return request.SizerType{}, fmt.Errorf("invalid sizer type value: %d", value)

exporter/exporterhelper/internal/queuebatch/internal/persistentqueue/sizer_conversion_test.go

@@ -0,0 +1,97 @@
+// Copyright The OpenTelemetry Authors
+// SPDX-License-Identifier: Apache-2.0
+
+package persistentqueue
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"go.opentelemetry.io/collector/exporter/exporterhelper/internal/request"
+)
+
+func TestSizerTypeToProto(t *testing.T) {
+	tests := []struct {
+		name           string
+		sizerType      request.SizerType
+		protoSizerType int32
+		wantErr        bool
+	}{
+		{
+			name:           "requests",
+			sizerType:      request.SizerTypeRequests,
+			protoSizerType: SizerTypeRequests,
+		},
+		{
+			name:           "items",
+			sizerType:      request.SizerTypeItems,
+			protoSizerType: SizerTypeItems,
+		},
+		{
+			name:           "bytes",
+			sizerType:      request.SizerTypeBytes,
+			protoSizerType: SizerTypeBytes,
+		},
+		{
+			name:           "invalid",
+			sizerType:      request.SizerType{},
+			protoSizerType: -1,
+			wantErr:        true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := SizerTypeToProto(tt.sizerType)
+			if tt.wantErr {
+				require.Error(t, err)
+				return
+			}
+			require.NoError(t, err)
+			assert.Equal(t, tt.protoSizerType, got)
+		})
+	}
+}
+
+func TestSizerTypeFromProto(t *testing.T) {
+	tests := []struct {
+		name           string
+		sizerType      request.SizerType
+		protoSizerType int32
+		wantErr        bool
+	}{
+		{
+			name:           "requests",
+			sizerType:      request.SizerTypeRequests,
+			protoSizerType: SizerTypeRequests,
+		},
+		{
+			name:           "items",
+			sizerType:      request.SizerTypeItems,
+			protoSizerType: SizerTypeItems,
+		},
+		{
+			name:           "bytes",
+			sizerType:      request.SizerTypeBytes,
+			protoSizerType: SizerTypeBytes,
+		},
+		{
+			name:           "invalid",
+			sizerType:      request.SizerType{},
+			protoSizerType: 3,
+			wantErr:        true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := SizerTypeFromProto(tt.protoSizerType)
+			if tt.wantErr {
+				require.Error(t, err)
+				return
+			}
+			require.NoError(t, err)
+			assert.Equal(t, tt.sizerType, got)
+		})
+	}
+}