Skip to content

Commit ad36545

Browse files
authored
[mdatagen] Fix bug where Histograms were marked as not supporting temporaly aggregation (#12168)
See https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L254 Signed-off-by: Bogdan Drutu <[email protected]>
1 parent 808e4a8 commit ad36545

File tree

3 files changed

+27
-2
lines changed

3 files changed

+27
-2
lines changed
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
7+
component: mdatagen
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Fix bug where Histograms were marked as not supporting temporaly aggregation
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [12168]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: [api, user]

cmd/mdatagen/internal/metric.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ func (d *Histogram) HasMonotonic() bool {
350350
}
351351

352352
func (d *Histogram) HasAggregated() bool {
353-
return false
353+
return true
354354
}
355355

356356
func (d *Histogram) Instrument() string {

cmd/mdatagen/internal/metric_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func TestMetricData(t *testing.T) {
2929
{&Sum{Async: true}, "Sum", true, true, "ObservableUpDownCounter", true},
3030
{&Sum{MetricValueType: MetricValueType{pmetric.NumberDataPointValueTypeInt}, Async: true}, "Sum", true, true, "Int64ObservableUpDownCounter", true},
3131
{&Sum{MetricValueType: MetricValueType{pmetric.NumberDataPointValueTypeDouble}, Async: true}, "Sum", true, true, "Float64ObservableUpDownCounter", true},
32-
{&Histogram{}, "Histogram", false, false, "Histogram", false},
32+
{&Histogram{}, "Histogram", true, false, "Histogram", false},
3333
} {
3434
assert.Equal(t, arg.wantType, arg.metricData.Type())
3535
assert.Equal(t, arg.wantHasAggregated, arg.metricData.HasAggregated())

0 commit comments

Comments
 (0)