Skip to content

Commit a3c7d95

Browse files
authored
[chore] Revert the change in processortest setting creation (#12107)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Revert the `nop_processor.NewNopSettings` change, as it is no longer needed. <!-- Issue number if applicable --> #### Link to tracking issue Fixes #11433 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation
1 parent c14d4f9 commit a3c7d95

File tree

3 files changed

+27
-4
lines changed

3 files changed

+27
-4
lines changed

.chloggen/revert-change-name.yaml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
7+
component: processorteset
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Revert the nop_processor.NewNopSettings change, as it is no longer needed
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [11433]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: [api]

processor/processortest/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ module go.opentelemetry.io/collector/processor/processortest
33
go 1.22.0
44

55
require (
6-
github.com/google/uuid v1.6.0
76
github.com/stretchr/testify v1.10.0
87
go.opentelemetry.io/collector/component v0.117.0
98
go.opentelemetry.io/collector/component/componentstatus v0.117.0
@@ -25,6 +24,7 @@ require (
2524
github.com/go-logr/logr v1.4.2 // indirect
2625
github.com/go-logr/stdr v1.2.2 // indirect
2726
github.com/gogo/protobuf v1.3.2 // indirect
27+
github.com/google/uuid v1.6.0 // indirect
2828
github.com/json-iterator/go v1.1.12 // indirect
2929
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
3030
github.com/modern-go/reflect2 v1.0.2 // indirect

processor/processortest/nop_processor.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ package processortest // import "go.opentelemetry.io/collector/processor/process
66
import (
77
"context"
88

9-
"github.com/google/uuid"
10-
119
"go.opentelemetry.io/collector/component"
1210
"go.opentelemetry.io/collector/component/componenttest"
1311
"go.opentelemetry.io/collector/consumer"
@@ -22,7 +20,7 @@ var nopType = component.MustNewType("nop")
2220
// NewNopSettings returns a new nop settings for Create* functions.
2321
func NewNopSettings() processor.Settings {
2422
return processor.Settings{
25-
ID: component.NewIDWithName(nopType, uuid.NewString()),
23+
ID: component.NewID(nopType),
2624
TelemetrySettings: componenttest.NewNopTelemetrySettings(),
2725
BuildInfo: component.NewDefaultBuildInfo(),
2826
}

0 commit comments

Comments
 (0)