Skip to content

Commit a3051d1

Browse files
committed
Apply changes requested in code review
Signed-off-by: Israel Blancas <[email protected]>
1 parent 7828204 commit a3051d1

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.chloggen/14091-add-megeto-profiles.yaml renamed to .chloggen/14091-add-mergeto-profiles.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ subtext:
2222
# Include 'user' if the change is relevant to end users.
2323
# Include 'api' if there is a change to a library API.
2424
# Default: '[user]'
25-
change_logs: []
25+
change_logs: [api]

pdata/pprofile/profiles_merge_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@ func TestProfilesMergeTo(t *testing.T) {
2727

2828
func TestProfilesMergeToSelf(t *testing.T) {
2929
profiles := NewProfiles()
30-
profiles.Dictionary().StringTable().Append("test")
30+
profiles.Dictionary().StringTable().Append("", "test")
3131
profiles.ResourceProfiles().AppendEmpty()
3232

3333
require.NoError(t, profiles.MergeTo(profiles))
3434

35-
assert.Equal(t, 1, profiles.Dictionary().StringTable().Len())
35+
assert.Equal(t, 2, profiles.Dictionary().StringTable().Len())
3636
assert.Equal(t, 1, profiles.ResourceProfiles().Len())
3737
}
3838

0 commit comments

Comments
 (0)