[receiverhelper] Update metric units (#10657)

#### Description
`1` isn't an informative unit for metrics, this should clarify their
units.

#### Link to tracking issue
Fixes
#10650

Author: crobert-1

.chloggen/receiverhelper_metric_units.yaml

@@ -0,0 +1,25 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: bug_fix
+
+# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
+component: receiverhelper
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Update units for internal telemetry
+
+# One or more tracking issues or pull requests related to the change
+issues: [10650]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: []

receiver/receiverhelper/documentation.md

@@ -12,44 +12,44 @@ Number of log records successfully pushed into the pipeline.
 
 | Unit | Metric Type | Value Type | Monotonic |
 | ---- | ----------- | ---------- | --------- |
-| 1 | Sum | Int | true |
+| {records} | Sum | Int | true |
 
 ### otelcol_receiver_accepted_metric_points
 
 Number of metric points successfully pushed into the pipeline.
 
 | Unit | Metric Type | Value Type | Monotonic |
 | ---- | ----------- | ---------- | --------- |
-| 1 | Sum | Int | true |
+| {datapoints} | Sum | Int | true |
 
 ### otelcol_receiver_accepted_spans
 
 Number of spans successfully pushed into the pipeline.
 
 | Unit | Metric Type | Value Type | Monotonic |
 | ---- | ----------- | ---------- | --------- |
-| 1 | Sum | Int | true |
+| {spans} | Sum | Int | true |
 
 ### otelcol_receiver_refused_log_records
 
 Number of log records that could not be pushed into the pipeline.
 
 | Unit | Metric Type | Value Type | Monotonic |
 | ---- | ----------- | ---------- | --------- |
-| 1 | Sum | Int | true |
+| {records} | Sum | Int | true |
 
 ### otelcol_receiver_refused_metric_points
 
 Number of metric points that could not be pushed into the pipeline.
 
 | Unit | Metric Type | Value Type | Monotonic |
 | ---- | ----------- | ---------- | --------- |
-| 1 | Sum | Int | true |
+| {datapoints} | Sum | Int | true |
 
 ### otelcol_receiver_refused_spans
 
 Number of spans that could not be pushed into the pipeline.
 
 | Unit | Metric Type | Value Type | Monotonic |
 | ---- | ----------- | ---------- | --------- |
-| 1 | Sum | Int | true |
+| {spans} | Sum | Int | true |

receiver/receiverhelper/internal/metadata/generated_telemetry.go

@@ -12,47 +12,47 @@ telemetry:
     receiver_accepted_spans:
       enabled: true
       description: Number of spans successfully pushed into the pipeline.
-      unit: "1"
+      unit: "{spans}"
       sum:
         value_type: int
         monotonic: true
 
     receiver_refused_spans:
       enabled: true
       description: Number of spans that could not be pushed into the pipeline.
-      unit: "1"
+      unit: "{spans}"
       sum:
         value_type: int
         monotonic: true
 
     receiver_accepted_metric_points:
       enabled: true
       description: Number of metric points successfully pushed into the pipeline.
-      unit: "1"
+      unit: "{datapoints}"
       sum:
         value_type: int
         monotonic: true
 
     receiver_refused_metric_points:
       enabled: true
       description: Number of metric points that could not be pushed into the pipeline.
-      unit: "1"
+      unit: "{datapoints}"
       sum:
         value_type: int
         monotonic: true
 
     receiver_accepted_log_records:
       enabled: true
       description: Number of log records successfully pushed into the pipeline.
-      unit: "1"
+      unit: "{records}"
       sum:
         value_type: int
         monotonic: true
 
     receiver_refused_log_records:
       enabled: true
       description: Number of log records that could not be pushed into the pipeline.
-      unit: "1"
+      unit: "{records}"
       sum:
         value_type: int
         monotonic: true