Improve RemoveIf for slices to not reference anymore the removed memory (#13522)

Signed-off-by: Bogdan Drutu <[email protected]>

Author: bogdandrutu

.chloggen/rm-refs.yaml

@@ -0,0 +1,25 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+
+# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
+component: pdata
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Improve RemoveIf for slices to not reference anymore the removed memory
+
+# One or more tracking issues or pull requests related to the change
+issues: [13522]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [user]

internal/cmd/pdatagen/internal/templates/slice.go.tmpl

@@ -133,6 +133,11 @@ func (es {{ .structName }}) RemoveIf(f func({{ .elementName }}) bool) {
 	newLen := 0
 	for i := 0; i < len(*es.{{ .origAccessor }}); i++ {
 		if f(es.At(i)) {
+			{{- if eq .type "sliceOfPtrs" }}
+			(*es.{{ .origAccessor }})[i] = nil
+			{{- else }}
+			(*es.{{ .origAccessor }})[i] = {{ .emptyOriginElement }}
+			{{- end }}
 			continue
 		}
 		if newLen == i {
@@ -141,6 +146,11 @@ func (es {{ .structName }}) RemoveIf(f func({{ .elementName }}) bool) {
 			continue
 		}
 		(*es.{{ .origAccessor }})[newLen] = (*es.{{ .origAccessor }})[i]
+		{{- if eq .type "sliceOfPtrs" }}
+		(*es.{{ .origAccessor }})[i] = nil
+		{{- else }}
+		(*es.{{ .origAccessor }})[i] = {{ .emptyOriginElement }}
+		{{- end }}
 		newLen++
 	}
 	*es.{{ .origAccessor }} = (*es.{{ .origAccessor }})[:newLen]

internal/cmd/pdatagen/internal/templates/slice_test.go.tmpl

@@ -143,6 +143,14 @@ func Test{{ .structName }}_RemoveIf(t *testing.T) {
 	assert.Equal(t, 5, filtered.Len())
 }
 
+func Test{{ .structName }}_RemoveIfAll(t *testing.T) {
+	got := generateTest{{ .structName }}()
+	got.RemoveIf(func(el {{ .elementName }}) bool {
+		return true
+	})
+	assert.Equal(t, 0, got.Len())
+}
+
 func Test{{ .structName }}All(t *testing.T) {
 	ms := generateTest{{ .structName }}()
 	assert.NotEmpty(t, ms.Len())