locations are only ever on Profiles. Remove interface

Author: dmathieu

pdata/pprofile/locations.go

@@ -7,18 +7,11 @@ import (
 	"errors"
 	"fmt"
 	"math"
-
-	"go.opentelemetry.io/collector/pdata/pcommon"
 )
 
-type locatable interface {
-	LocationIndices() pcommon.Int32Slice
-}
-
-// FromLocationIndices builds a slice containing all the locations of a record.
-// The record can be any struct that implements a `LocationIndices` method.
-// Updates made to the returned map will not be applied back to the record.
-func FromLocationIndices(table LocationSlice, record locatable) LocationSlice {
+// FromLocationIndices builds a slice containing all the locations of a Profile.
+// Updates made to the returned map will not be applied back to the Profile.
+func FromLocationIndices(table LocationSlice, record Profile) LocationSlice {
 	m := NewLocationSlice()
 	m.EnsureCapacity(record.LocationIndices().Len())
 
@@ -32,12 +25,11 @@ func FromLocationIndices(table LocationSlice, record locatable) LocationSlice {
 
 var errTooManyLocationTableEntries = errors.New("too many entries in LocationTable")
 
-// PutLocation updates a LocationTable and a record's LocationIndices to
+// PutLocation updates a LocationTable and a Profile's LocationIndices to
 // add or update a location.
-// The record can be any struct that implements a `LocationIndices` method.
-func PutLocation(table LocationSlice, record locatable, loc Location) error {
-	for i, locIdx := range record.LocationIndices().All() {
-		idx := int(locIdx)
+func PutLocation(table LocationSlice, record Profile, loc Location) error {
+	for i := range record.LocationIndices().All() {
+		idx := int(record.LocationIndices().At(i))
 		if idx < 0 || idx >= table.Len() {
 			return fmt.Errorf("index value %d out of range in LocationIndices[%d]", idx, i)
 		}

pdata/pprofile/locations_test.go

@@ -110,7 +110,7 @@ func BenchmarkPutLocation(b *testing.B) {
 		name     string
 		location Location
 
-		runBefore func(*testing.B, LocationSlice, locatable)
+		runBefore func(*testing.B, LocationSlice, Profile)
 	}{
 		{
 			name:     "with a new location",
@@ -124,7 +124,7 @@ func BenchmarkPutLocation(b *testing.B) {
 				return l
 			}(),
 
-			runBefore: func(_ *testing.B, table LocationSlice, _ locatable) {
+			runBefore: func(_ *testing.B, table LocationSlice, _ Profile) {
 				l := table.AppendEmpty()
 				l.SetAddress(1)
 			},
@@ -133,7 +133,7 @@ func BenchmarkPutLocation(b *testing.B) {
 			name:     "with a duplicate location",
 			location: NewLocation(),
 
-			runBefore: func(_ *testing.B, table LocationSlice, obj locatable) {
+			runBefore: func(_ *testing.B, table LocationSlice, obj Profile) {
 				require.NoError(b, PutLocation(table, obj, NewLocation()))
 			},
 		},
@@ -145,7 +145,7 @@ func BenchmarkPutLocation(b *testing.B) {
 				return l
 			}(),
 
-			runBefore: func(_ *testing.B, table LocationSlice, _ locatable) {
+			runBefore: func(_ *testing.B, table LocationSlice, _ Profile) {
 				for i := range 100 {
 					l := table.AppendEmpty()
 					l.SetAddress(uint64(i)) //nolint:gosec // overflow checked