Skip to content

Commit 98bea6e

Browse files
authored
Change health_check default endpoint to 0.0.0.0:13133 (#2828)
This commits brings back default configuration of the health_check extension to make sure it works in k8s-like environments without extra configuration as it was before the latest change #2782. Resolves: #2827
1 parent c4108c1 commit 98bea6e

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

extension/healthcheckextension/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ liveness and/or readiness probe on Kubernetes.
66

77
The following settings are required:
88

9-
- `endpoint` (default = localhost:13133): Address to publish the health check status to
9+
- `endpoint` (default = 0.0.0.0:13133): Address to publish the health check status to
1010
- `port` (default = 13133): [deprecated] What port to expose HTTP health information.
1111

1212
Example:

extension/healthcheckextension/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,6 @@ type Config struct {
3131

3232
// TCPAddr represents a tcp endpoint address that is to publish the health
3333
// check status.
34-
// The default endpoint is "localhost:13133".
34+
// The default endpoint is "0.0.0.0:13133".
3535
TCPAddr confignet.TCPAddr `mapstructure:",squash"`
3636
}

extension/healthcheckextension/factory.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ const (
2727
// The value of extension "type" in configuration.
2828
typeStr = "health_check"
2929

30-
defaultEndpoint = "localhost:13133"
30+
// Use 0.0.0.0 to make the health check endpoint accessible
31+
// in container orchestration environments like Kubernetes.
32+
defaultEndpoint = "0.0.0.0:13133"
3133
)
3234

3335
// NewFactory creates a factory for HealthCheck extension.

0 commit comments

Comments
 (0)