Skip to content

Commit 946da65

Browse files
committed
[filter] unexport CombinedFilter
1 parent 9c3481b commit 946da65

File tree

2 files changed

+30
-5
lines changed

2 files changed

+30
-5
lines changed

.chloggen/filter.yaml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
7+
component: filter
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Unexport the `filter.CombinedFilter` struct
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: []
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: [api]

filter/config.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"regexp"
99
)
1010

11-
// Config configures the matching behavior of a FilterSet.
11+
// Config configures the matching behavior of a Filter.
1212
type Config struct {
1313
Strict string `mapstructure:"strict"`
1414
Regex string `mapstructure:"regexp"`
@@ -32,14 +32,14 @@ func (c Config) Validate() error {
3232
return nil
3333
}
3434

35-
type CombinedFilter struct {
35+
type combinedFilter struct {
3636
stricts map[any]struct{}
3737
regexes []*regexp.Regexp
3838
}
3939

40-
// CreateFilter creates a Filter from yaml config.
40+
// CreateFilter creates a Filter out of a set of Config configuration objects.
4141
func CreateFilter(configs []Config) Filter {
42-
cf := &CombinedFilter{
42+
cf := &combinedFilter{
4343
stricts: make(map[any]struct{}),
4444
}
4545
for _, config := range configs {
@@ -56,7 +56,7 @@ func CreateFilter(configs []Config) Filter {
5656
return cf
5757
}
5858

59-
func (cf *CombinedFilter) Matches(toMatch any) bool {
59+
func (cf *combinedFilter) Matches(toMatch any) bool {
6060
_, ok := cf.stricts[toMatch]
6161
if ok {
6262
return ok

0 commit comments

Comments
 (0)