Skip to content

Commit 8d3c19d

Browse files
mx-psisongy23
andauthored
[internal/localhostgate] Correctly log message about local host gate (#10529)
Fixes log intended to be logged when the feature gate is enabled, not disabled. #### Link to tracking issue Relates to #8510, updates #10352 --------- Co-authored-by: Yang Song <[email protected]>
1 parent cd639e5 commit 8d3c19d

File tree

2 files changed

+27
-2
lines changed

2 files changed

+27
-2
lines changed

.chloggen/localhostgate-info-log.yaml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
7+
component: internal/localhostgate
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Correctly log info message when `component.UseLocalHostAsDefaultHost` is enabled
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [8510]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: []

internal/localhostgate/featuregate.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ func EndpointForPort(port int) string {
5959

6060
// LogAboutUseLocalHostAsDefault logs about the upcoming change from 0.0.0.0 to localhost on server-like components.
6161
func LogAboutUseLocalHostAsDefault(logger *zap.Logger) {
62-
if !UseLocalHostAsDefaultHostfeatureGate.IsEnabled() {
62+
if UseLocalHostAsDefaultHostfeatureGate.IsEnabled() {
6363
logger.Info(
64-
"The default endpoints for all servers in components have changed to use localhost instead of 0.0.0.0. Use the feature gate to temporarily revert to the previous default.",
64+
"The default endpoints for all servers in components have changed to use localhost instead of 0.0.0.0. Disable the feature gate to temporarily revert to the previous default.",
6565
zap.String("feature gate ID", UseLocalHostAsDefaultHostID),
6666
)
6767
}

0 commit comments

Comments
 (0)