Skip to content

Commit 8cc1fde

Browse files
committed
use scheme directly in providerModules map keys
Signed-off-by: ChrsMark <[email protected]>
1 parent cb1e2fc commit 8cc1fde

File tree

6 files changed

+14
-18
lines changed

6 files changed

+14
-18
lines changed

cmd/builder/internal/builder/templates/main.go.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func main() {
4747
},
4848
}, ProviderModules: map[string]string{
4949
{{- range .ConfmapProviders}}
50-
"{{.Name}}": "{{.GoMod}}",
50+
{{.Name}}.NewFactory().Create(confmap.ProviderSettings{}).Scheme(): "{{.GoMod}}",
5151
{{- end}}
5252
},
5353
}

cmd/otelcorecol/main.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

otelcol/collector.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ type CollectorSettings struct {
6969
// confmap.Providers watch for configuration changes.
7070
ConfigProviderSettings ConfigProviderSettings
7171

72-
// ProviderModules maps provider types to their respective go modules.
72+
// ProviderModules maps provider schemes to their respective go modules.
7373
ProviderModules map[string]string
7474

7575
// LoggingOptions provides a way to change behavior of zap logging.

otelcol/command_components.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -116,14 +116,10 @@ func newComponentsCommand(set CollectorSettings) *cobra.Command {
116116
}
117117
components.BuildInfo = set.BuildInfo
118118

119-
confmapProviderFactories := set.ConfigProviderSettings.ResolverSettings.ProviderFactories
120-
for _, confmapProvider := range confmapProviderFactories {
121-
provider := confmapProvider.Create(set.ConfigProviderSettings.ResolverSettings.ProviderSettings)
122-
scheme := provider.Scheme()
123-
module := set.ProviderModules[scheme+"provider"]
119+
for providerScheme, providerModuleModule := range set.ProviderModules {
124120
components.Providers = append(components.Providers, componentWithoutStability{
125-
Name: scheme,
126-
Module: module,
121+
Name: providerScheme,
122+
Module: providerModuleModule,
127123
})
128124
}
129125

otelcol/command_components_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ func TestNewBuildSubCommand(t *testing.T) {
2222
Factories: nopFactories,
2323
ConfigProviderSettings: newDefaultConfigProviderSettings(t, []string{filepath.Join("testdata", "otelcol-nop.yaml")}),
2424
ProviderModules: map[string]string{
25-
"envprovider": "go.opentelemetry.io/collector/confmap/provider/envprovider v1.2.3",
26-
"fileprovider": "go.opentelemetry.io/collector/confmap/provider/fileprovider v1.2.3",
25+
"env": "go.opentelemetry.io/collector/confmap/provider/envprovider v1.2.3",
26+
"file": "go.opentelemetry.io/collector/confmap/provider/fileprovider v1.2.3",
2727
},
2828
}
2929
cmd := NewCommand(set)

otelcol/testdata/components-output.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ extensions:
4242
stability:
4343
extension: Stable
4444
providers:
45-
- name: file
46-
module: go.opentelemetry.io/collector/confmap/provider/fileprovider v1.2.3
4745
- name: env
4846
module: go.opentelemetry.io/collector/confmap/provider/envprovider v1.2.3
47+
- name: file
48+
module: go.opentelemetry.io/collector/confmap/provider/fileprovider v1.2.3

0 commit comments

Comments
 (0)