Small style issues in code, unnecessary wrapping (#3187)

Signed-off-by: Bogdan Drutu <[email protected]>

Author: bogdandrutu

config/internal/configsource/manager_test.go

@@ -576,8 +576,8 @@ type valueEntry struct {
 	WatchForUpdateFn func() error
 }
 
-var _ (configsource.ConfigSource) = (*testConfigSource)(nil)
-var _ (configsource.Session) = (*testConfigSource)(nil)
+var _ configsource.ConfigSource = (*testConfigSource)(nil)
+var _ configsource.Session = (*testConfigSource)(nil)
 
 func (t *testConfigSource) NewSession(context.Context) (configsource.Session, error) {
 	if t.ErrOnNewSession != nil {
@@ -629,7 +629,7 @@ type retrieved struct {
 	watchForUpdateFn func() error
 }
 
-var _ (configsource.Retrieved) = (*retrieved)(nil)
+var _ configsource.Retrieved = (*retrieved)(nil)
 
 func (r *retrieved) Value() interface{} {
 	return r.value

exporter/jaegerexporter/exporter.go

@@ -80,7 +80,7 @@ type protoGRPCSender struct {
 	connStateReporterInterval time.Duration
 	stateChangeCallbacks      []func(connectivity.State)
 
-	stopCh   chan (struct{})
+	stopCh   chan struct{}
 	stopped  bool
 	stopLock sync.Mutex
 }
@@ -96,7 +96,7 @@ func newProtoGRPCSender(logger *zap.Logger, name string, cl jaegerproto.Collecto
 		conn:                      conn,
 		connStateReporterInterval: time.Second,
 
-		stopCh: make(chan (struct{})),
+		stopCh: make(chan struct{}),
 	}
 	s.AddStateChangeCallback(s.onStateChange)
 	return s

exporter/jaegerexporter/exporter_test.go

@@ -253,7 +253,7 @@ func TestConnectionStateChange(t *testing.T) {
 	}
 	sender := &protoGRPCSender{
 		logger:                    zap.NewNop(),
-		stopCh:                    make(chan (struct{})),
+		stopCh:                    make(chan struct{}),
 		conn:                      sr,
 		connStateReporterInterval: 10 * time.Millisecond,
 	}
@@ -284,7 +284,7 @@ func TestConnectionReporterEndsOnStopped(t *testing.T) {
 
 	sender := &protoGRPCSender{
 		logger:                    zap.NewNop(),
-		stopCh:                    make(chan (struct{})),
+		stopCh:                    make(chan struct{}),
 		conn:                      sr,
 		connStateReporterInterval: 10 * time.Millisecond,
 	}

receiver/hostmetricsreceiver/internal/scraper/processesscraper/processes_scraper_test.go

@@ -51,8 +51,8 @@ func TestScrape(t *testing.T) {
 
 	for _, test := range testCases {
 		t.Run(test.name, func(t *testing.T) {
-			expectProcessesCountMetric := (runtime.GOOS == "linux" || runtime.GOOS == "openbsd" || runtime.GOOS == "darwin" || runtime.GOOS == "freebsd")
-			expectProcessesCreatedMetric := (runtime.GOOS == "linux" || runtime.GOOS == "openbsd")
+			expectProcessesCountMetric := runtime.GOOS == "linux" || runtime.GOOS == "openbsd" || runtime.GOOS == "darwin" || runtime.GOOS == "freebsd"
+			expectProcessesCreatedMetric := runtime.GOOS == "linux" || runtime.GOOS == "openbsd"
 
 			scraper := newProcessesScraper(context.Background(), &Config{})
 			if test.miscFunc != nil {