File tree Expand file tree Collapse file tree 2 files changed +9
-1
lines changed
exporter/exporterhelper/internal Expand file tree Collapse file tree 2 files changed +9
-1
lines changed Original file line number Diff line number Diff line change @@ -376,6 +376,14 @@ func TestBatchSender_ConcurrencyLimitReached(t *testing.T) {
376
376
expectedItems : 51 ,
377
377
},
378
378
}
379
+
380
+ // Why do we not expect the same behavior when usePullingBasedExporterQueueBatcher is true?
381
+ // This test checks that when concurrency limit of batch_sender is reached, the batch_sender will flush immediately.
382
+ // To avoid blocking, the concurrency limit is set to the number of concurrent goroutines that are in charge of
383
+ // reading from the queue and adding to batch. With the new model, we are pulling instead of pushing so we don't
384
+ // block the reading goroutine anymore.
385
+ defer setFeatureGateForTest (t , usePullingBasedExporterQueueBatcher , false )()
386
+
379
387
for _ , tt := range tests {
380
388
t .Run (tt .name , func (t * testing.T ) {
381
389
qCfg := exporterqueue .NewDefaultConfig ()
Original file line number Diff line number Diff line change @@ -19,7 +19,7 @@ import (
19
19
20
20
var usePullingBasedExporterQueueBatcher = featuregate .GlobalRegistry ().MustRegister (
21
21
"exporter.UsePullingBasedExporterQueueBatcher" ,
22
- featuregate .StageAlpha ,
22
+ featuregate .StageBeta ,
23
23
featuregate .WithRegisterFromVersion ("v0.115.0" ),
24
24
featuregate .WithRegisterDescription ("if set to true, turns on the pulling-based exporter queue bathcer" ),
25
25
)
You can’t perform that action at this time.
0 commit comments