[receiver/prometheusremotewrite] skip emitting empty metrics #44149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
requested review from
a team,
ArthurSens and
dashpole
as code owners
dashpole
approved these changes
Nov 12, 2025
ArthurSens
approved these changes
Nov 12, 2025
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
I wouldn't say it's "Chore" though. We're changing behavior here. Could you add a changlog entry?
perebaj
approved these changes
Nov 12, 2025
songy23
changed the title
songy23
added
Skip Changelog
Contributor
Author
|
@ArthurSens I've added a change log. |
Member
|
Hmmm, weird. The diff with |
ArthurSens
added
the
ready to merge
aureleoules
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Nov 14, 2025
…lemetry#44149) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description We should ideally empty a metric only if it has some datapoints in it. Right now, we can emit empty metric if the `target_info` arrives first and normal metrics arrives in subsequent request. This PR adds a simple check to skip `ConsumeMetrics` if metric count is 0. <!--Describe what testing was performed and which tests were added.--> #### Testing Updated tests --------- Co-authored-by: Yang Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should ideally empty a metric only if it has some datapoints in it. Right now, we can emit empty metric if the
target_infoarrives first and normal metrics arrives in subsequent request.This PR adds a simple check to skip
ConsumeMetricsif metric count is 0.Testing
Updated tests