Skip to content

Conversation

@ChrsMark
Copy link
Member

@ChrsMark ChrsMark requested a review from a team as a code owner September 25, 2025 14:11
@github-actions github-actions bot added the processor/tailsampling Tail sampling processor label Sep 25, 2025
@github-actions github-actions bot requested a review from portertech September 25, 2025 14:11
@ChrsMark
Copy link
Member Author

ChrsMark commented Oct 2, 2025

@portertech please take a look

@ChrsMark ChrsMark requested a review from atoulme October 20, 2025 07:57
@ChrsMark ChrsMark added the ready to merge Code review completed; ready to merge by maintainers label Oct 20, 2025
@edmocosta
Copy link
Contributor

edmocosta commented Oct 21, 2025

It seems some unit tests are failing due to this change, is that right?

Running target 'test' in module 'processor/tailsamplingprocessor' as part of group 'processor-1'
make --no-print-directory -C processor/tailsamplingprocessor test

=== FAIL: . TestMetricsWithComponentID (0.00s)
    processor_telemetry_test.go:316: [Description not equal:
        expected: Count of traces that were sampled or not per sampling policy
        actual: Count of traces that were sampled or not per sampling policy [development]]
    processor_telemetry_test.go:316: [Description not equal:
        expected: Latency (in microseconds) of a given sampling policy
        actual: Latency (in microseconds) of a given sampling policy [development]]

=== FAIL: . TestMetricsCountSampled/not_sampled/otelcol_processor_tail_sampling_global_count_traces_sampled (0.00s)
    processor_telemetry_test.go:598: [Description not equal:
        expected: Global count of traces that were sampled or not by at least one policy
        actual: Global count of traces that were sampled or not by at least one policy [development]]

...

@ChrsMark
Copy link
Member Author

ChrsMark commented Oct 21, 2025

It seems some unit tests are failing due to this change, is that right?

Running target 'test' in module 'processor/tailsamplingprocessor' as part of group 'processor-1'
make --no-print-directory -C processor/tailsamplingprocessor test

=== FAIL: . TestMetricsWithComponentID (0.00s)
    processor_telemetry_test.go:316: [Description not equal:
        expected: Count of traces that were sampled or not per sampling policy
        actual: Count of traces that were sampled or not per sampling policy [development]]
    processor_telemetry_test.go:316: [Description not equal:
        expected: Latency (in microseconds) of a given sampling policy
        actual: Latency (in microseconds) of a given sampling policy [development]]

=== FAIL: . TestMetricsCountSampled/not_sampled/otelcol_processor_tail_sampling_global_count_traces_sampled (0.00s)
    processor_telemetry_test.go:598: [Description not equal:
        expected: Global count of traces that were sampled or not by at least one policy
        actual: Global count of traces that were sampled or not by at least one policy [development]]

...

Ouch, missed that believing it was just flakiness based on the fact that the change should only affect auto-generated code. Thank's for catching this! Should be fixed now.

@lukaszgryglicki
Copy link

/easycla

@songy23 songy23 merged commit 2927dc8 into open-telemetry:main Oct 21, 2025
189 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

processor/tailsampling Tail sampling processor ready to merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants