-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[chore][tailsamplingprocessor] Add stability level per metric #42934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
songy23
merged 23 commits into
open-telemetry:main
from
ChrsMark:tailsamplingprocessor_metric_stability
Oct 21, 2025
Merged
[chore][tailsamplingprocessor] Add stability level per metric #42934
songy23
merged 23 commits into
open-telemetry:main
from
ChrsMark:tailsamplingprocessor_metric_stability
Oct 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrsMark <[email protected]>
Member
Author
|
@portertech please take a look |
MovieStoreGuy
approved these changes
Oct 20, 2025
carsonip
approved these changes
Oct 20, 2025
Contributor
|
It seems some unit tests are failing due to this change, is that right? Running target 'test' in module 'processor/tailsamplingprocessor' as part of group 'processor-1'
make --no-print-directory -C processor/tailsamplingprocessor test
=== FAIL: . TestMetricsWithComponentID (0.00s)
processor_telemetry_test.go:316: [Description not equal:
expected: Count of traces that were sampled or not per sampling policy
actual: Count of traces that were sampled or not per sampling policy [development]]
processor_telemetry_test.go:316: [Description not equal:
expected: Latency (in microseconds) of a given sampling policy
actual: Latency (in microseconds) of a given sampling policy [development]]
=== FAIL: . TestMetricsCountSampled/not_sampled/otelcol_processor_tail_sampling_global_count_traces_sampled (0.00s)
processor_telemetry_test.go:598: [Description not equal:
expected: Global count of traces that were sampled or not by at least one policy
actual: Global count of traces that were sampled or not by at least one policy [development]]
... |
Signed-off-by: ChrsMark <[email protected]>
Member
Author
Ouch, missed that believing it was just flakiness based on the fact that the change should only affect auto-generated code. Thank's for catching this! Should be fixed now. |
carsonip
approved these changes
Oct 21, 2025
|
/easycla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
processor/tailsampling
Tail sampling processor
ready to merge
Code review completed; ready to merge by maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
open-telemetry/opentelemetry-collector#13756 added support for exposing metrics' stability level in the generated documentation. This PR makes use of this functionality.
We start by setting the stability of all metrics to
development. More info about levels can be found at https://github.com/open-telemetry/opentelemetry-specification/blob/v1.49.0/oteps/0232-maturity-of-otel.md#maturity-levels.Related to:
Link to tracking issue
Fixes ~
Testing
~
Documentation
Updated