-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[receiver/kafka] 0.124.0 release broke default log text encoding #39793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Thanks for reporting this @kuiperda, and sorry for the breakage. Working on a fix now. |
/label -needs-triage |
Thanks for the swift response! |
Fix is up: #39806 |
atoulme
pushed a commit
that referenced
this issue
May 2, 2025
#### Description Fix support for text encodings with hyphens in their names. If the encoding name has a hyphen then it is an invalid extension ID, but we should not return an error due to this if it's a built-in encoding. #### Link to tracking issue Fixes #39793 #### Testing Added a new unit test covering hyphenated text encoding names (fails without the associated fix). #### Documentation N/A
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this issue
May 6, 2025
…#39806) #### Description Fix support for text encodings with hyphens in their names. If the encoding name has a hyphen then it is an invalid extension ID, but we should not return an error due to this if it's a built-in encoding. #### Link to tracking issue Fixes open-telemetry#39793 #### Testing Added a new unit test covering hyphenated text encoding names (fails without the associated fix). #### Documentation N/A
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this issue
May 20, 2025
…#39806) #### Description Fix support for text encodings with hyphens in their names. If the encoding name has a hyphen then it is an invalid extension ID, but we should not return an error due to this if it's a built-in encoding. #### Link to tracking issue Fixes open-telemetry#39793 #### Testing Added a new unit test covering hyphenated text encoding names (fails without the associated fix). #### Documentation N/A
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this issue
May 23, 2025
…#39806) #### Description Fix support for text encodings with hyphens in their names. If the encoding name has a hyphen then it is an invalid extension ID, but we should not return an error due to this if it's a built-in encoding. #### Link to tracking issue Fixes open-telemetry#39793 #### Testing Added a new unit test covering hyphenated text encoding names (fails without the associated fix). #### Documentation N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Component(s)
receiver/kafka
What happened?
Description
Release 0.124.0 updated the kafka receiver's
topic
andencoding
fields.0.124.0+ Collectors using
text_utf-8
as theirlog::encoding
encounter this error:As part of the update, this PR made a change that errors if the
-
character is used in theencoding
. See this function, specificallycomponent.NewType(encoding)
:Looking at the
func newLogsUnmarshaler
in the same file, it looks likeutf8
andutf16
are the expected format now, but the readme still recommendsutf-8
and the default appears to still beutf-8
. There is a test validating usage ofutf16
but notutf8
orutf-8
.I do not have Kafka set up but a collector will error because of this even before complaining that there are no brokers to connect to.
Steps to Reproduce
Run a 0.124.0 collector with a kafkareceiver using
text_utf-8
as the log encoding. It will immediately error due to the-
in the encoding. The config I shared is still using the old encoding/topic fields, but nesting them underlogs:
instead still hits the same error.Expected Result
The receiver should not error when using a hyphenated value like
text_utf-8
as the log encoding.Furthermore, the recommended and default format for text encoding should work. If the breaking change was intentional, the documentation should be updated accordingly.
Tests should be added to cover this case.
Actual Result
The collector errors due to the
-
in the log encoding.Collector version
0.124.0
Environment information
Environment
OS: macOS/darwin Sequoia 15.0.1
Compiler(if manually compiled): go 1.24.0
OpenTelemetry Collector configuration
Log output
Additional context
No response
The text was updated successfully, but these errors were encountered: