[receiver/prometheusreceiver]: Allow to configure EnableCreatedTimest… #40380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ampZeroIngestion in prometheus receiver
LukaszByczynski
requested review from
dashpole,
ArthurSens and
a team
as code owners
atoulme
reviewed
Jun 4, 2025
| @@ -34,6 +34,9 @@ type Config struct { | |||
| UseStartTimeMetric bool `mapstructure:"use_start_time_metric"` | |||
| StartTimeMetricRegex string `mapstructure:"start_time_metric_regex"` | |||
|
|
|||
| // EnableCreatedTimestampZeroIngestion - enables TODO! | |||
There was a problem hiding this comment.
is this comment still in progress?
|
Please rebase off latest main and add a changelog. Please see my comment regarding the code comment. Once you have addressed those items, please mark the PR as ready to review again. |
|
Thanks @LukaszByczynski, but #40355 is implementing the same thing with a slightly different approach. Since that PR is almost merged, I'm closing this one. I hope that's ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to configure EnableCreatedTimestampZeroIngestion in prometheus receiver
Description
This PR fixes a perfomance regression described here
Link to tracking issue
Fixes 40379
Testing
Configuration tests.
Documentation
not applicable