Add datasource, aka "connection string", option to sqlserverreceiver
#39235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
receiver/sqlserver
Run Windows
atoulme
approved these changes
Apr 9, 2025
LucianoGiannotti
pushed a commit
to LucianoGiannotti/opentelemetry-collector-contrib
that referenced
this pull request
Apr 9, 2025
…er` (open-telemetry#39235) #### Description Adds an option, `datasource`, that allows full control of the connection string used when connecting to the DB. There are many possible variations that are useful that can be specified via this option, e.g.: one could enable Windows authentication and have the collector run with an account configured to access the SQL server. #### Testing Covered the new option in an extended validation test and used it to connect to a SQL server using Windows credentials. #### Documentation Added a note about the new option. --------- Co-authored-by: Antoine Toulme <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…er` (open-telemetry#39235) #### Description Adds an option, `datasource`, that allows full control of the connection string used when connecting to the DB. There are many possible variations that are useful that can be specified via this option, e.g.: one could enable Windows authentication and have the collector run with an account configured to access the SQL server. #### Testing Covered the new option in an extended validation test and used it to connect to a SQL server using Windows credentials. #### Documentation Added a note about the new option. --------- Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an option,
datasource, that allows full control of the connection string used when connecting to the DB. There are many possible variations that are useful that can be specified via this option, e.g.: one could enable Windows authentication and have the collector run with an account configured to access the SQL server.Testing
Covered the new option in an extended validation test and used it to connect to a SQL server using Windows credentials.
Documentation
Added a note about the new option.