Skip to content

[exporter/zipkin] Support scope attributes #39206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mx-psi opened this issue Apr 7, 2025 · 2 comments
Open

[exporter/zipkin] Support scope attributes #39206

mx-psi opened this issue Apr 7, 2025 · 2 comments
Labels
enhancement New feature or request exporter/zipkin good first issue Good for newcomers help wanted Extra attention is needed priority:p1 High

Comments

@mx-psi
Copy link
Member

mx-psi commented Apr 7, 2025

Component(s)

exporter/zipkin

Is your feature request related to a problem? Please describe.

The Zipkin exporter currently ignores the scope attributes on OTLP payloads. This leads to missing information and we have a repo-wide initiative to support scope attributes, see #38744

Describe the solution you'd like

Scope attributes are added as tags, having precedence over resource attributes but being overwrritten by span attributes with the same name (to be consistent with how we add resource attributes).

We should take open-telemetry/opentelemetry-specification/issues/4473 into account to make sure we have a consistent behavior across implementations.

Describe alternatives you've considered

Alternatively, resource and scope attributes can be added under a particular namespace that is reserved for attributes of a particular type. There is precedent for this on the Prometheus mapping.

Additional context

Also relates to open-telemetry/opentelemetry-specification/issues/2535

@mx-psi mx-psi added enhancement New feature or request needs triage New item requiring triage labels Apr 7, 2025
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@andrzej-stencel
Copy link
Member

This should be implemented in /pkg/translator/zipkin/zipkinv2/from_translator.go, as this is what is used by the Zipkin exporter: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.126.0/exporter/zipkinexporter/zipkin.go#L19.

To be more specific, the extraceScopeTags function should go through the scope attributes and add them as zipking tags in zTags map, similar to what the function resourceToZipkinEndpointServiceNameAndAttributeMap is already doing for resource attributes.

@andrzej-stencel andrzej-stencel added the good first issue Good for newcomers label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/zipkin good first issue Good for newcomers help wanted Extra attention is needed priority:p1 High
Projects
None yet
Development

No branches or pull requests

2 participants